Closed
Bug 631352
Opened 15 years ago
Closed 15 years ago
Dynamic changes to :lang() not reflected
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: jag+mozilla, Assigned: bzbarsky)
Details
(Keywords: regression, Whiteboard: [softblocker])
Attachments
(2 files)
|
1.59 KB,
text/html
|
Details | |
|
3.12 KB,
patch
|
dbaron
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
Given something like:
<html lang="en">
…
a { display: none; }
a.nl:lang(nl), a.en:lang(en) { display: inline; }
…
function toggle() { html.lang = html.lang != "en" ? "en" : "nl"; }
…
<a lang="en" …>Gebruik Nederlands</a><a lang="nl" …>Use English</a>
In 3.6 this successfully toggles between the two languages, in 4.0 nothing appears to happen, or the link disappears, sometimes after mousing over it.
See the testcase.
Regressed in
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=979b65e6b73e&tochange=befec51e10ab
(found by going immediately to those nightlies, not by bisection), presumably because of bug 479655 + bug 494117.
blocking2.0: --- → ?
|
Assignee | |
Comment 2•15 years ago
|
||
Yeah, indeed, since changing @lang affects whether :lang matches for descendants due to GetLang walking up the tree. Looks like this is the only pseudo-class with this property.
Fix coming up, with simple testcase.
jag, webkit seems to have a bug with this too. Do you know whether there's a bug on them for this?
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #509779 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Comment on attachment 509779 [details] [diff] [review]
Changes to @lang need to restyle all descendants.
r=dbaron
Attachment #509779 -
Flags: review?(dbaron)
Attachment #509779 -
Flags: review+
Attachment #509779 -
Flags: approval2.0+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [need review] → [need landing]
blocking2.0: ? → final+
Whiteboard: [need landing] → [need landing][softblocker]
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [need landing][softblocker] → [softblocker]
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•