631356 - Set an attribute on monochrome toolbars to make life easier for extensions

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[:Paolo Amadini]

Attachment: The patch

Patch on top of bug 626382. Example add-on stylesheet with this patch:

toolbar[monochrome] #my-button {
  list-style-image: url(icon16-monochrome.png);
}

Comment 1

[:Paolo Amadini]

Attachment: The patch

Revised patch on top of bug 626382.

Comment 2

[:Paolo Amadini]

Attachment: The patch

Revised patch on top of bug 626382, the correct file this time.

Sorry for the noise.

Comment 3

[:Paolo Amadini]

Attachment: The patch

Revised patch on top of bug 626382.

Comment 4

[Asaf Romano (gone)]

The more I think about this, the more I'm convinced this belongs to theme's chrome.manifest (replacing the counter-reset hack).

Comment 5

[Dão Gottwald [:dao]]

I'm not convinced that this bug is the right direction at all. The idea that all icons should be monochrome seems a bit odd, and it's extra load for extension authors.

Comment 6

[Jez]

Wasn't the point that the UX team wanted people to basically make a monochrome version of their theme to 'fit in' with the MacOSX look?

I still haven't heard, by the way, whether there's a plan to deal with there being duplicate themes with different icon sizes (which are bound to turn up), if you remove the option for users to choose between small and large icons.

Comment 7

[:Paolo Amadini]

(In reply to comment #6)
> Wasn't the point that the UX team wanted people to basically make a monochrome
> version of their theme to 'fit in' with the MacOSX look?

That was my understanding too, and it's mentioned in the article in the bug URL:

http://blog.mozilla.com/addons/2010/12/02/toolbar-buttons-in-firefox-4/

I'm setting the "uiwanted" keyword to get feedback if this is still desired.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 509636 [details] [diff] [review]
The patch

I don't think we should set the expectation that add-on authors need to create various icon versions. This is also not going to work for jetpack-style add-ons. Classic add-ons that want this can target OS X in chrome.manifest.

Comment 9

[:Paolo Amadini]

(In reply to Dão Gottwald [:dao] from comment #8)

Thank you for reviewing this! Since we haven't heard from the UX team on the issue
in a long time, I suppose this is not something they're considering anymore.