Closed
Bug 631406
Opened 15 years ago
Closed 15 years ago
PeekOffsetNoAmount doesn't accept null as its second argument
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Keywords: assertion)
Attachments
(1 file, 1 obsolete file)
|
1.08 KB,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
Calls to nsTextFrame::CheckVisibility cause nsTextFrame::PeekOffsetNoAmount to assert for no good reason because the second argument shouldn't be null...
|
Assignee | |
Comment 1•15 years ago
|
||
I hit this assertion when I was working on bug 629878.
|
|
Assignee | |
Comment 2•15 years ago
|
||
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #509640 -
Flags: review?(roc)
Attachment #509640 -
Flags: approval2.0?
Is this the right patch?
|
|
Assignee | |
Comment 4•15 years ago
|
||
(In reply to comment #3)
> Is this the right patch?
No! Sorry :-)
Attachment #509640 -
Attachment is obsolete: true
Attachment #509646 -
Flags: review?(roc)
Attachment #509646 -
Flags: approval2.0?
Attachment #509640 -
Flags: review?(roc)
Attachment #509640 -
Flags: approval2.0?
Attachment #509646 -
Flags: review?(roc)
Attachment #509646 -
Flags: review+
Attachment #509646 -
Flags: approval2.0?
Attachment #509646 -
Flags: approval2.0+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•