Closed Bug 631406 Opened 9 years ago Closed 9 years ago

PeekOffsetNoAmount doesn't accept null as its second argument

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: ehsan, Assigned: ehsan)

Details

(Keywords: assertion)

Attachments

(1 file, 1 obsolete file)

Patch (v1)
1.08 KB, patch
roc
: review+
roc
: approval2.0+
Details | Diff | Splinter Review 
Calls to nsTextFrame::CheckVisibility cause nsTextFrame::PeekOffsetNoAmount to assert for no good reason because the second argument shouldn't be null...
I hit this assertion when I was working on bug 629878.
Attached patch Patch (v1) (obsolete) — — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #509640 - Flags: review?(roc)
Attachment #509640 - Flags: approval2.0?
Keywords: assertion
Attached patch Patch (v1) — — Splinter Review 
(In reply to comment #3)
> Is this the right patch?

No!  Sorry :-)
Attachment #509640 - Attachment is obsolete: true
Attachment #509646 - Flags: review?(roc)
Attachment #509646 - Flags: approval2.0?
Attachment #509640 - Flags: review?(roc)
Attachment #509640 - Flags: approval2.0?
Attachment #509646 - Flags: review?(roc)
Attachment #509646 - Flags: review+
Attachment #509646 - Flags: approval2.0?
Attachment #509646 - Flags: approval2.0+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/9c9bb1b6e94a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.