631412 - Bug 629401 breaks non-libxul builds due to unresolved reference to nsContentUtils::DispatchTrustedEvent(nsIDocument*, nsISupports*, nsAString_internal const&, int, int, int*)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(no longer active)]

Undefined symbols:
  "nsContentUtils::DispatchTrustedEvent(nsIDocument*, nsISupports*, nsAString_internal const&, int, int, int*)", referenced from:
      CarbonEventModelFailureEvent::Run()      in nsNPAPIPluginInstance.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[5]: *** [libgkplugin.dylib] Error 1
make[4]: *** [libs] Error 2
make[3]: *** [libs_tier_platform] Error 2
make[2]: *** [tier_platform] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Comment 1

[Daniel Holbert [:dholbert]]

FWIW, this breaks my non-libxul build on x86_64 Linux, too, with the same mention of "In function `CarbonEventModelFailureEvent::Run()':"

(Is CarbonEventModelFailureEvent even supposed to be built under Linux?  My initial assumption was that it was Mac-specific, based on the name, but I don't really know.)

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Borrow the code from nsContentUtils for non-libxul builds.  (This makes me sad.  Real sad.)

Comment 3

[(no longer active)]

Attachment: Patch (v2)

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/5e1f1bb2bb87

Comment 5

[Josh Aas]

Thanks for the fix Ehsan!