631491 - toolbar's iconsize attribute is not updated correctly after switching themes

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Markus Stange [:mstange]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110203 Firefox/4.0b12pre
Built from http://hg.mozilla.org/mozilla-central/rev/f2a6a78478dc

Steps to reproduce:
1. Use the default theme on Mac with large icons mode.
Now iconsize="large" is set on the toolbox and iconsize="small" on the toolbar.
2. Install and enable this theme: https://addons.mozilla.org/en-US/firefox/addon/walnut2-for-firefox/
3. Restart Firefox.

Expected results:
After the restart, iconsize="large" should be set on both the toolbox and the toolbar since this theme doesn't use counter-reset: smallicons.

Actual results:
The toolbars still have iconsize="small" set on them. Restarting another time doesn't change this, only double-flipping the checkbox in the customization panel does.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

simple solution: don't persist the adjusted iconsize

Comment 3

[Pardal Freudenthal (:ShareBird)]

Any chance this patch to be landed before 4.0? This bug will for sure annoy users from third-party themes and it seems this is a no-risk patch at all.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0d3e9943f463

Comment 6

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0

Verified issue and it's no longer present.

Comment 7

[AndreiD[QA]]

WFM on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Sadly, this "no risk" patch caused a regression.