631500 - Let openUILink accept an object with named parameters

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

As opposed to:

openUILinkIn(url, whereToOpenLink(event), { relatedToCurrent: true });

This doesn't work:

openUILink(url, event, { relatedToCurrent: true });

The attached patch fixes that.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 509728 [details] [diff] [review]
patch

>diff --git a/browser/base/content/utilityOverlay.js b/browser/base/content/utilityOverlay.js

>+function openUILink(url, e, ignoreButton, ignoreAlt, allowKeywordFixup, postData, referrerUrl) {

>+    params = {
>+      allowThirdPartyFixup: allowThirdPartyFixup,

>+      referrerURI: referrerURI

these don't match up (allowKeywordFixup and referrerUrl)

Should have a test that would've caught this if there isn't already.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

fixed the argument names

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/35c61da53e1a

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/35c61da53e1a

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

marking this for backout tracking for esr based on dep bug 734076

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Do you mean backport tracking? We don't want to back this out anywhere :)

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 606870 [details] [diff] [review]
patch v2

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: blocks bug 734076
User impact if declined: 
Fix Landed on Version: landed with 14, no known regressions
Risk to taking this patch (and alternatives if risky): purely additional, backwards-compatible change, so should not cause any trouble
String or UUID changes made by this patch: none

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 606870 [details] [diff] [review]
patch v2

Could use this on beta too, for the same reasons.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 606870 [details] [diff] [review]
patch v2

(nevermind, I was confused, this is already on beta)

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

blocking bug 734076 which is tracked for ESR, please go ahead and land.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-esr10/rev/07ebb24b04ab

Comment 12

[u279076]

Does this need a test?