Closed
Bug 631500
Opened 13 years ago
Closed 12 years ago
Let openUILink accept an object with named parameters
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [qa?])
Attachments
(1 file, 1 obsolete file)
1.76 KB,
patch
|
Gavin
:
review+
lsblakk
:
approval-mozilla-esr10+
|
Details | Diff | Splinter Review |
As opposed to: openUILinkIn(url, whereToOpenLink(event), { relatedToCurrent: true }); This doesn't work: openUILink(url, event, { relatedToCurrent: true }); The attached patch fixes that.
Attachment #509728 -
Flags: review?(gavin.sharp)
Comment 1•13 years ago
|
||
Comment on attachment 509728 [details] [diff] [review] patch >diff --git a/browser/base/content/utilityOverlay.js b/browser/base/content/utilityOverlay.js >+function openUILink(url, e, ignoreButton, ignoreAlt, allowKeywordFixup, postData, referrerUrl) { >+ params = { >+ allowThirdPartyFixup: allowThirdPartyFixup, >+ referrerURI: referrerURI these don't match up (allowKeywordFixup and referrerUrl) Should have a test that would've caught this if there isn't already.
Attachment #509728 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Updated•12 years ago
|
Blocks: CVE-2012-1966
Assignee | ||
Comment 2•12 years ago
|
||
fixed the argument names
Attachment #509728 -
Attachment is obsolete: true
Attachment #606870 -
Flags: review?(gavin.sharp)
Updated•12 years ago
|
Attachment #606870 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/35c61da53e1a
Target Milestone: --- → Firefox 14
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/35c61da53e1a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
marking this for backout tracking for esr based on dep bug 734076
status-firefox-esr10:
--- → affected
tracking-firefox-esr10:
--- → 14+
Comment 6•12 years ago
|
||
Do you mean backport tracking? We don't want to back this out anywhere :)
Comment 7•12 years ago
|
||
Comment on attachment 606870 [details] [diff] [review] patch v2 [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: blocks bug 734076 User impact if declined: Fix Landed on Version: landed with 14, no known regressions Risk to taking this patch (and alternatives if risky): purely additional, backwards-compatible change, so should not cause any trouble String or UUID changes made by this patch: none
Attachment #606870 -
Flags: approval-mozilla-esr10?
Comment 8•12 years ago
|
||
Comment on attachment 606870 [details] [diff] [review] patch v2 Could use this on beta too, for the same reasons.
Attachment #606870 -
Flags: approval-mozilla-beta?
Comment 9•12 years ago
|
||
Comment on attachment 606870 [details] [diff] [review] patch v2 (nevermind, I was confused, this is already on beta)
Attachment #606870 -
Flags: approval-mozilla-beta?
Updated•12 years ago
|
Attachment #606870 -
Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
Comment 10•12 years ago
|
||
blocking bug 734076 which is tracked for ESR, please go ahead and land.
You need to log in
before you can comment on or make changes to this bug.
Description
•