631575 - Failing "!mPresShell && !mWindow" assertion in CreateDeviceContext() after SetDocument(), in content processes

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

+++ This bug was initially created as a clone of Bug #631359 +++

The assertion failing is

###!!! ASSERTION: This will screw up our existing presentation: '!mPresShell && !mWindow', file /home/cjones/mozilla/mozilla-central/layout

Last unresolved issue in original bug

> - hit MakeWindow(this=0x28362b0) breakpoint below
> nsDocShell::CreateContentViewer.  Hm.
> - hit failing CreateDeviceContext(this=0x28362b0) assertion below
> txMozillaXMLOutput::createResultDocument.

Looks like a likely regression from bug 581536.  Wasn't biting firefox,
presumably, because there is no mWindow there for content frames or something,
right?

I _think_, though roc should confirm, that the right fix is to null out mWindow
right before the InitInternal call in SetDocumentInternal.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Clear the old window when setting a new document, and re-enable tests disabled in bug 631359

Not sure whether you or bz should review this, it's a fairly inbred bug.  But a trivial patch so doesn't really matter.

With this and bug 631585, we're back to passing crashtest-ipc.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 510539 [details] [diff] [review]
Clear the old window when setting a new document, and re-enable tests disabled in bug 631359

Don't think this is a risky patch, and the benefit is passing crashtest-ipc tests.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 510539 [details] [diff] [review]
Clear the old window when setting a new document, and re-enable tests disabled in bug 631359

a=dbaron, but only if you land prior to final beta (i.e., land today or tomorrow)

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Done.  Thanks again!

http://hg.mozilla.org/mozilla-central/rev/9685f88199a6