631680 - Remove Deki opensearch link in head

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Janet Swisher]

http://mdn.uservoice.com/forums/51389-mdn-website-feedback-http-developer-mozilla-org/suggestions/1275179-fix-the-mdc-open-search-description

The wiki page heads contain the following search link:
\<link href="/deki/gui/opensearch.php?type=description" title="MDC Search" type="application/opensearchdescription+xml" rel="search">

This refers to the old, broken Deki-based search, and should be removed.

Comment 1

[Michal Čaplygin [:myf]]

And why not just replace deprecated …/Special:Search?search={searchTerms} with with nowadays functional …/en-US/search?q={searchTerms} URL (google-json-driven page) in the XML file? I've tried it and result works well …
http://eldar.cz/myf/lab/mdc-opensearch/add.html

Comment 2

[Luke Crouch [:groovecoder]]

Craig,

Will we push MindTouch code for 0.9.4? If so we might try to fix this bug for 0.9.4. If not we can push it off to 0.9.5.

Comment 3

[Craig Cook (:craigcook)]

0.9.4 will include some MindTouch updates, but I'm not sure how best to go about addressing this issue. That search link gets automatically inserted by the same function that outputs the feed links and some other dynamic bits (GetHeadLinks in /includes/OutputPage.php). 

Option 1: We could omit the function call from the skin's head, but then we'd lose the dynamic feed links, though we could probably replace them ourselves in a new function.

Option 2: We can very easily edit that GetHeadLinks function to just omit the search link while leaving everything else intact, but then we're touching core code that can be overwritten in future updates. At the very least we'll need to make the same change when we upgrade to v10.

Option 1 will take more effort to regenerate some of the dynamic bits the MindTouch code already gives us for free. Option 2 entails commenting out a single line. While I normally hate modifying third-party code, it seems relatively harmless to do so in this case so I'm leaning to option 2 for simplicity's sake.

Comment 4

[Eric Shepherd [:sheppy]]

I think at this point modifying the code is fine as long as we keep in mind we're getting ready to deploy the MindTouch 10 update, which may mean re-doing it.

Comment 5

[Luke Crouch [:groovecoder]]

Craig now that we've done the MT 10 update can we look at changing the MT skin to remove this <link> element?

Comment 6

[Craig Cook (:craigcook)]

r89951 has a modified version of /includes/OutputPage.php. There's some chance that the version of the file I was working with differs from the version in production or on stage (and production and stage may differ since it may change between Deki versions) so ideally we should do a diff on the existing file to see if it's safe to deploy this hack. All we need to do is comment out a single line (line 945 in this version) and nothing else should be touched.

If this file does differ significantly from what's in production, we should pull the latest version from production into SVN over this version, recommenting the offending line if necessary. 

tl;dr: SVN should mirror production and the code I've committed here may not, but I have no way of knowing. Proceed with care.

Comment 7

[Luke Crouch [:groovecoder]]

this should be live on production now, right?