631682 - window.onload event is fired before background image for html element in style

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

I will attach a test case.

Please see bug 580873#c248  and bug 580873#c265.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: A test case

I could not find a way to know loading background image in style is completed, so checked that the background image is in image cache. As mkato said in bug 580873#c265, this test case works if html element is changed to body element, so I thinks the check works fine for this bug.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

This test fails for me without the patch, passes with.  Worst-case, it could randomly pass even if someone regresses this bug...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Nice catch.

What's going on here is that background image loads start when we compute the background style.  For non-root elements, this happens in nsCSSFrameConstructor::ConstructFramesFromItem because we make and explicit GetStyleBackground call there.  But for the root element we don't call ConstructFramesFromItem.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 509977 [details] [diff] [review]
Proposed fix

r=dbaron

Comment 5

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/16cc18d74a8c