Closed Bug 631746 Opened 13 years ago Closed 13 years ago

Search bar: Search engine cannot be switched

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: dfghjkjhg, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre

Search bar:   Sometimes the search engine cannot be switched any more.

For each try to switch to another search engine, the error console shows:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIBrowserSearchService.currentEngine]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml :: set_currentEngine :: line 0"  data: no]

Reproducible: Always
Version: unspecified → Trunk
same here.

Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre ID:20110207030345
Status: UNCONFIRMED → NEW
Ever confirmed: true
For me this doesn't happen when I first open the browser, it happens a while later. Unfortunately I haven't been able to pinpoint any STR yet. Opening and closing "Manage Search Engines" sometimes fixes it, but not always.
Keywords: regression
Does it also happen for you in a fresh profile? Anyone has installed user search engines?
Also on Mac OS X 10.6.6 -> all/all.

I haven't tested with a fresh user profile and no extra search plugins yet. I'm hoping to find a reliable method of reproduction first.
OS: Windows 7 → All
Hardware: x86 → All
The search.sqlite file would be helpful then. If you don't mind and can attach it.
Got this too today with http://hg.mozilla.org/mozilla-central/rev/3470891975c7 on a non-Default Profile. Only Bugzilla Tabs were open. Got no Error Console Output and closing some Tabs made the Issue go away within the same Browser Session.
I hit this often since upgrading to beta 11, it did not occur in beta 10. The search box refuses to change engines and the exception noted in Comment 0 appears in the error console. Usually requires restarting the browser to fix it for me. It gets stuck on either a custom or default engine. This profile has only been used with Firefox 4 betas, I do have a few non-default engines.

search.sqlite from this profile attached.
Wolf, do you have found any clear steps we could use to reproduce? Otherwise it would be a great help if you could check the nightly builds between beta 10 and 11 to find the regression bug. The only fix we had for the search bar in Firefox 4 is bug 623110. So testing nightly builds around its landing would be a good start.
And this patch has been landed on 2011-02-01. This bug was filed on 2011-02-02 which means it would be the first build with this change included. Can you please confirm?
So far (about ten times), opening a new window and changing engines in that window has been a 100% working workaround for me.
Same problem

Mozilla/5.0 (Windows NT 5.1; rv:2.0b11) Gecko/20100101 Firefox/4.0b11
Same problem

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11) Gecko/20100101 Firefox/4.0b11
Can everyone of you please check a Firefox 4 beta 10 build if this problem persists there too? That would be a good information.
I have been testing FF4 since beta 7 and I never had this issue before beta 11. I first had this issue just after restarting after updating to beta 11.
Gavin - wha happen?
So for those who experience this bug I have some questions. Would be great to get some answers so we have a better correlation to what is involved here.

* Which search engines do you have installed?
* Have you changed the order of installed search engines?
* What's your default engine?
* Have you Bing installed yourself before?
* Which steps are necessary to reproduce this issue?
(In reply to comment #19)
> * Which search engines do you have installed?
en-US default (in program dir) + bugzilla,amazon-jp,google-jp,wikipedia-jp,yahoo-jp,daum-kr,wikipedia-kr (in profile dir)

> * Have you changed the order of installed search engines?
yes.

> * What's your default engine?
google-jp

> * Have you Bing installed yourself before?
no.

> * Which steps are necessary to reproduce this issue?
no STR.
this happens suddenly.
(In reply to comment #19)
> * Which search engines do you have installed?
Google
Merriam-Webster Dictionary
Google Translate ja->en
Wikipedia (en)
Wikipedia (Nederlands)
Wikipedia (ja)
Voip-info.org wiki
YouTube
IMDb
Mycroft Project
Google Maps
Van Dale Woordenboek

> * Have you changed the order of installed search engines?
Yes

> * What's your default engine?
It seems I don't have a default engine. Mozilla allways
starts with the last one selected (usually Google).

> * Have you Bing installed yourself before?
I remember I removed it. It had been installed (but I would
never do that by myself).

> * Which steps are necessary to reproduce this issue?
Unknown. It just happens.

I really use the search engine quite often and I never had
this problem with FF4.0b10. It started with FF4.0b11.
(In reply to comment #19)
> * Which search engines do you have installed?
Google
Wikipedia-en
Wiktionnaire-en
Wikipedia-fr
Wiktionnaire-fr

> * Have you changed the order of installed search engines?
Yes

> * What's your default engine?
Google

> * Have you Bing installed yourself before?
No

> * Which steps are necessary to reproduce this issue?
It does not happen all the time. Sometimes when trying to change the search engine, clicking on the name or label of a search engine in the search engine combo/drop-down list does not result in that engine to be selected. Up to now I only had this problem when trying to switch back to the default search engine (Google) after having used an other one (Wikipedia or Wiktionnaire).
I will try to find a way to reproduce it. I have tried to restart the browser several times and then each time to switch several times the search engines, but I have not yet succeeded to reproduce it.
Can the people seeing this set browser.search.log to true, and paste any relevant looking messages from around the exception when this occurs? It's very odd for that function to be throwing that exception - I don't see how it could be happening offhand, unless it's some weird xpconnect issue.
(In reply to comment #18)
> The only change we had here is the landing of bug 623110.
> 
> Aurele, could you please test those two builds. Would be interested in if the
> second one fails.
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2011/02/2011-02-01-03-mozilla-central/firefox-4.0b11pre.en-US.win32.zip
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2011/02/2011-02-02-03-mozilla-central/firefox-4.0b11pre.en-US.win32.zip

I've set browser.search.log to true and reproduced this on second build. Right before first error comes another error:
Error: no element found
Source File: http://www.odnoklassniki.ru/push?cmd=PeriodicManager&gwt.requested=704856d1&st.cmd=userGuests
Line: 1

When problem resolves itself after switching tabs and other usual actions, following log entries appear:
NOTIFY: Engine: "Team Fortress Wiki (en)"; Verb: "engine-current"
getVisibleEngines: getting all visible engines
These messages do not appear before error from description.

Will try first version now.
When I closed browser, Error console apparently have not closed, and two more errors appeared:

Error: L$ is not defined
Source File: http://www.odnoklassniki.ru/web/gwt/704856d1/one.app.community.dk.gwt.dm.block.Block/065F37DA199227396B1807CCD8880249.cache.html
Line: 9327

Link on source file contained long list of code apparently sorted by length. Errors appeared on these lines:

function wS(){tS();return mrb(u6b,1144,5,[nS,rS,oS,pS,qS,sS])}
function K$(a){return function(){return L$(a,this,arguments)}}
function Mpg(c){$wnd.uploadComplete=function(a,b){c.Sj(a,b)}}

I'm not sure if this relevant (as problem fixed itself at that point) but tab where Source file indicated issue occured (from previous comment) was still opened.
(In reply to comment #18)
> The only change we had here is the landing of bug 623110.
> 
> Aurele, could you please test those two builds. Would be interested in if the
> second one fails.
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2011/02/2011-02-01-03-mozilla-central/firefox-4.0b11pre.en-US.win32.zip
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2011/02/2011-02-02-03-mozilla-central/firefox-4.0b11pre.en-US.win32.zip

Reproduced on first version. Following errors appear before errors from description:
Error: _gat is not defined
Source File: http://www.alexa.com/siteinfo/io9.com
Line: 2723
Error: atrk is not defined
Source File: http://www.alexa.com/siteinfo/io9.com
Line: 2741
You can ignore any entries whose "Source File:" points to a URL starting with "http" - those are web page errors that just happened to occur around the same time (the Error Console displays errors/warning for both Firefox code and web page code).
I will see what I can do to reproduce this issue. I will try with the mentioned search engines first. Thanks everyone.
Keywords: qawanted
(In reply to comment #26)
> Reproduced on first version. Following errors appear before errors from

Could you please check older beta releases of Firefox 4? I wonder when it has been started for you.
I cannot offer steps to reproduce at the moment nor a regression window (too much hassle with profile manager juggling. I believe that nightly builds still use the default profile?), anyway, the error console says this for me to when switching search engines and failing:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIBrowserSearchService.currentEngine]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml :: set_currentEngine :: line 0"  data: no]

I never had this problem in previous betas.
Hey, something I haven't seen so far in the posted build identifiers, are you all using an en-US locale or one of your language?
(In reply to comment #31)
> Hey, something I haven't seen so far in the posted build identifiers, are you
> all using an en-US locale or one of your language?

French version
(In reply to comment #31)
> Hey, something I haven't seen so far in the posted build identifiers, are you
> all using an en-US locale or one of your language?

en-US Nightly/Hourly.
* Which search engines do you have installed?
Google
Amazon.de
Leo dictionary eng-ger
Wikipedia de
Wikipedia en
Youtube
IMDB
Thomann.de
Last.fm
Wikitionary de
Bibleserver.com (for researchs sake only :p)
Bing
* Have you changed the order of installed search engines?
Yes
* What's your default engine?
Google
* Have you Bing installed yourself before?
No. Dont know where it comes from.
* Which steps are necessary to reproduce this issue?
No idea.
(In reply to comment #29)
> (In reply to comment #26)
> > Reproduced on first version. Following errors appear before errors from
> 
> Could you please check older beta releases of Firefox 4? I wonder when it has
> been started for you.

I've been using 4.0b10 since right after your message. Normally, issue would already appear on b11, but it does not. It seems it really got broken somewhere between b10 and b11.
I have tried a couple of different localized builds and with other search engines installed but wasn't able to reproduce this problem. Does anyone mind to share the profile with us? Before doing so you would have to clean it up from private data like stored passwords and cookies. Even better would be a fresh profile, which shows the same behavior.

If you want to share the profile please send it to hskupin(at)mozilla.com, but don't attach it to this bug. Thanks.
Good news! I'm able to reproduce it finally now thanks to the information from bug 635020 which is probably a dupe. I will investigate and find steps to reproduce.
Given the steps on bug 635020 it somehow is related to restoring the last closed tab. It's kinda hard to reproduce, and I'm not able to anymore since I have enabled the seach log. Something I have noticed is, that when installing a new search engines, it sometimes magically gets resorted and ends up right before the last default engine. Could be related.
Can anyone seeing this try to reproduce with a build from here:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/gsharp@mozilla.com-f1ef841741c6/

This build includes more elaborate search service logging that hopefully will help pinpoint the issue. The log output goes to both stdout and the Error Console's "Messages" tab. Reproducing the error and then including the log output from around the time the error occurred (as an attachment, ideally) would be very helpful.
Was anyone able to run some tests with Gavin's tryserver build and got some more in-detail logs for that error? We would really appreciate that help so we can get this fixed. Thanks.
I tried running it for about a day the day before yesterday, but unfortunately I never saw the bug happen with it. (Come to think about it, I don't think the bug happened to me with beta 11 yesterday either, but I hardly used the search bar then so that could have been just luck.)
Torbjörn: thanks for trying!

The builds have disappeared from the FTP server - I've put new ones (built yesterday) at https://people.mozilla.com/~gavin/search/ . Output from these builds when the bug occurs would be very helpful.
The bug did not occur for me the last few days, I think the x64 nightly 2011-02-19 was the version since it did not occur, but I couldn't tell for sure. I'm sure it didn't occur since 2011-02-20 nightly though.
When I get stuck on a specific search engine, a workaround for me is to click the search dropdown and select that search engine again.  It then returns to normal expected behaviour (until it acts up again).
Occasionally when this happens, I can fix it by bringing up Panorama, selecting a tab in a different tab group, and changing the search engine there. However, it seems that's only worked in a minority of cases by now; most of the time I have to close and reopen the window before I can change search engines.
I confirm this bug in 4.0b12.
I ran trace build for a total of three days now, but bug did not reproduce. I will continue to run trace version.
I didn't encounter this bug any more since 4.0b12 and hope it stays away.
I too have not seen this bug for some time neither on trace version or on b12/RC1. I wonder if it was caused by some addon?
I have not run into this issue in a while. I have two search engine related add-ons, the second has not been updated for Firefox 4:

https://addons.mozilla.org/en-us/firefox/addon/context-search/
https://addons.mozilla.org/en-US/firefox/addon/add-to-search-bar/
For me this problem went away when I upgraded to 4.0b12, and I haven't seen it since then. I'm not aware of adding/removing any add-ons in that time.
Given that we are not able to reproduce this issue I would like to close this bug as incomplete for now. I will watch for upcoming bug reports now that Firefox 4 has been released. Lets see if this issue was only visible for beta users.
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: qawanted
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.