Clean up the global scope a bit [CreateMailWindowGlobals()]

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

10.00 KB, patch
Karsten Düsterloh
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
An itsy bitsy clean up bug focusing on CreateMailWindowGlobals()

Q.v.
Bug 416666 (part 2) Clean up Thunderbird's global scope a bit.
Bug 440616 (part 1 v2) Clean up Thunderbird's global scope a bit more (mail session and 3pane commands).
(Assignee)

Comment 1

6 years ago
Created attachment 510006 [details] [diff] [review]
Patch v1.0 WIP

>    //Create datasources
> +  var prefix = "@mozilla.org/rdf/datasource;1?name=";
> +  var accountManagerDSContractID = prefix + "msgaccountmanager";
> +  var folderDSContractID         = prefix + "mailnewsfolders";
> +
>    accountManagerDataSource = Components.classes[accountManagerDSContractID].getService();
>    folderDataSource         = Components.classes[folderDSContractID].getService();

If I do .getService(nsiRDFDataSource) here. Can I remove the QIs from the rest of suite/mailnews/ ?
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #510006 - Flags: review?(mnyromyr)
Attachment #510006 - Flags: feedback?(neil)

Comment 2

6 years ago
(In reply to comment #1)
> >    accountManagerDataSource = Components.classes[accountManagerDSContractID].getService();
> >    folderDataSource         = Components.classes[folderDSContractID].getService();
> 
> If I do .getService(nsiRDFDataSource) here. Can I remove the QIs from the rest
> of suite/mailnews/ ?

If you mean the four QIs to nsIRDFDataSource, then yes, they could go.

Updated

6 years ago
Attachment #510006 - Flags: feedback?(neil) → feedback+
(Assignee)

Comment 3

6 years ago
Created attachment 510268 [details] [diff] [review]
Patch v1.0a remove unnecessary QIs

> neil@parkwaycc.co.uk      2011-02-05 07:09:28 PST
> 
> (In reply to comment #1)
>>>    accountManagerDataSource = Components.classes[accountManagerDSContractID].getService();
>>>    folderDataSource         = Components.classes[folderDSContractID].getService();
>> 
>> If I do .getService(nsiRDFDataSource) here. Can I remove the QIs from the rest
>> of suite/mailnews/ ?
> 
> If you mean the four QIs to nsIRDFDataSource, then yes, they could go.
Jolly Good.
Attachment #510006 - Attachment is obsolete: true
Attachment #510268 - Flags: superreview?(neil)
Attachment #510268 - Flags: review?(mnyromyr)
Attachment #510006 - Flags: review?(mnyromyr)

Updated

6 years ago
Attachment #510268 - Flags: superreview?(neil) → superreview+

Updated

6 years ago
Attachment #510268 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 4

6 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/dbc2f57e7b63
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.