631773 - Clean up the global scope a bit [CreateMailWindowGlobals()]

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Philip Chee]

An itsy bitsy clean up bug focusing on CreateMailWindowGlobals()

Q.v.
Bug 416666 (part 2) Clean up Thunderbird's global scope a bit.
Bug 440616 (part 1 v2) Clean up Thunderbird's global scope a bit more (mail session and 3pane commands).

Comment 1

[Philip Chee]

Attachment: Patch v1.0 WIP

>    //Create datasources
> +  var prefix = "@mozilla.org/rdf/datasource;1?name=";
> +  var accountManagerDSContractID = prefix + "msgaccountmanager";
> +  var folderDSContractID         = prefix + "mailnewsfolders";
> +
>    accountManagerDataSource = Components.classes[accountManagerDSContractID].getService();
>    folderDataSource         = Components.classes[folderDSContractID].getService();

If I do .getService(nsiRDFDataSource) here. Can I remove the QIs from the rest of suite/mailnews/ ?

Comment 2

[[e-mail]]

(In reply to comment #1)
> >    accountManagerDataSource = Components.classes[accountManagerDSContractID].getService();
> >    folderDataSource         = Components.classes[folderDSContractID].getService();
> 
> If I do .getService(nsiRDFDataSource) here. Can I remove the QIs from the rest
> of suite/mailnews/ ?

If you mean the four QIs to nsIRDFDataSource, then yes, they could go.

Comment 3

[Philip Chee]

Attachment: Patch v1.0a remove unnecessary QIs

> [e-mail]      2011-02-05 07:09:28 PST
> 
> (In reply to comment #1)
>>>    accountManagerDataSource = Components.classes[accountManagerDSContractID].getService();
>>>    folderDataSource         = Components.classes[folderDSContractID].getService();
>> 
>> If I do .getService(nsiRDFDataSource) here. Can I remove the QIs from the rest
>> of suite/mailnews/ ?
> 
> If you mean the four QIs to nsIRDFDataSource, then yes, they could go.
Jolly Good.

Comment 4

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/dbc2f57e7b63