Closed
Bug 631837
Opened 13 years ago
Closed 13 years ago
Make querySelector iterate the DOM instead of recursing
Categories
(Core :: DOM: Core & HTML, defect, P1)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
5.00 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
We need to kill off RuleProcessorData first, though.
Assignee | ||
Updated•13 years ago
|
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Comment on attachment 510046 [details] [diff] [review] wip >+ if (!cur->IsNodeOfType(nsINode::eELEMENT)) { IsElement()? (twice)
Assignee | ||
Comment 3•13 years ago
|
||
Yeah, this code predates IsElement() existing, iirc. In case it wasn't clear I wrote this months ago, on top of another patch series, and haven't merged it to tip in forever. It won't apply, it won't compile, and it won't run. ;) And I didn't want to spend the time today on making it do any of those things. But they'll happen!
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #520127 -
Flags: review?(jonas)
Assignee | ||
Updated•13 years ago
|
Attachment #510046 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Whiteboard: [need review]
Comment on attachment 520127 [details] [diff] [review] Stop doing recursive tree traversal in querySelector(All). Sweet!
Attachment #520127 -
Flags: review?(jonas) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [need review] → [need bug 598832 fixed]
Assignee | ||
Comment 6•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/df90f3ca7deb Either this or bug 598832 or the combination of the two gave us a 20-25% win on dromaeo_css. ;)
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need bug 598832 fixed]
Target Milestone: --- → mozilla2.2
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•