631837 - Make querySelector iterate the DOM instead of recursing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

We need to kill off RuleProcessorData first, though.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: wip

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 510046 [details] [diff] [review]
wip

>+    if (!cur->IsNodeOfType(nsINode::eELEMENT)) {

IsElement()? (twice)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, this code predates IsElement() existing, iirc.  In case it wasn't clear I wrote this months ago, on top of another patch series, and haven't merged it to tip in forever.  It won't apply, it won't compile, and it won't run.  ;)  And I didn't want to spend the time today on making it do any of those things.  But they'll happen!

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop doing recursive tree traversal in querySelector(All).

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 520127 [details] [diff] [review]
Stop doing recursive tree traversal in querySelector(All).

Sweet!

Comment 6

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/df90f3ca7deb

Either this or bug 598832 or the combination of the two gave us a 20-25% win on dromaeo_css.  ;)