Last Comment Bug 631852 - Port |Bug 602715 - Sync UI: Only mention enabled engines in client wipe confirmation dialog|
: Port |Bug 602715 - Sync UI: Only mention enabled engines in client wipe confi...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Sync UI (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: 602715
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-05 15:32 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2011-02-10 13:43 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: comment 3] (9.16 KB, patch)
2011-02-05 15:32 PST, Jens Hatlak (:InvisibleSmiley)
neil: review+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2011-02-05 15:32:00 PST
Created attachment 510061 [details] [diff] [review]
patch [Checkin: comment 3]

From bug 602715 comment 0:

STR:
 1. Open Sync Preferences
 2. Under "Sync My", check only one item (e.g. bookmarks), and uncheck
everything else
 3. Click "Manage Account" and then "Reset Sync"
 4. Choose "Replace all data on this computer with my Sync data", and click
Next
 5. Sync brings up a very scary dialog saying:

"All Minefield data on this computer will be deleted, including the following:
   XXX bookmarks
   YYY days of history
   ZZZ passwords
 WARNING: This will result in all Minefield data on this computer being
replaced!"

Truthfully, only the options I've checked (in this case, bookmarks) will be
replaced -- everything else is NOT replaced.


In the .js, most changes are just reindentation. A diff -w would show you:
- removed '// XXX' (now self-explanatory)
- added 'if (Weave.Engines.get(XXX).enabled) {'
- added '} else { XXX }'
- added 'let' before second 'stm' (now inside an 'if')
- added hiding of new prefsWipe element if prefs not enabled.
Comment 1 neil@parkwaycc.co.uk 2011-02-06 11:54:03 PST
Comment on attachment 510061 [details] [diff] [review]
patch [Checkin: comment 3]

When I originally tested Sync, I only synced my tabs, which means I've got nothing that I can Reset ;-) I don't suppose we can detect this?
Comment 2 Jens Hatlak (:InvisibleSmiley) 2011-02-06 12:19:58 PST
(In reply to comment #1)
> When I originally tested Sync, I only synced my tabs, which means I've got
> nothing that I can Reset ;-) I don't suppose we can detect this?

I'd say this investigation should be done in bug 616821. Will add a note there.
Comment 3 Jens Hatlak (:InvisibleSmiley) 2011-02-06 13:16:16 PST
Comment on attachment 510061 [details] [diff] [review]
patch [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/cc940d2a1b9f

Note You need to log in before you can comment on or make changes to this bug.