The default bug view has changed. See this FAQ.

Port |Bug 602715 - Sync UI: Only mention enabled engines in client wipe confirmation dialog|

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Sync UI
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 510061 [details] [diff] [review]
patch [Checkin: comment 3]

From bug 602715 comment 0:

STR:
 1. Open Sync Preferences
 2. Under "Sync My", check only one item (e.g. bookmarks), and uncheck
everything else
 3. Click "Manage Account" and then "Reset Sync"
 4. Choose "Replace all data on this computer with my Sync data", and click
Next
 5. Sync brings up a very scary dialog saying:

"All Minefield data on this computer will be deleted, including the following:
   XXX bookmarks
   YYY days of history
   ZZZ passwords
 WARNING: This will result in all Minefield data on this computer being
replaced!"

Truthfully, only the options I've checked (in this case, bookmarks) will be
replaced -- everything else is NOT replaced.


In the .js, most changes are just reindentation. A diff -w would show you:
- removed '// XXX' (now self-explanatory)
- added 'if (Weave.Engines.get(XXX).enabled) {'
- added '} else { XXX }'
- added 'let' before second 'stm' (now inside an 'if')
- added hiding of new prefsWipe element if prefs not enabled.
Attachment #510061 - Flags: review?(neil)

Comment 1

6 years ago
Comment on attachment 510061 [details] [diff] [review]
patch [Checkin: comment 3]

When I originally tested Sync, I only synced my tabs, which means I've got nothing that I can Reset ;-) I don't suppose we can detect this?
Attachment #510061 - Flags: review?(neil) → review+
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> When I originally tested Sync, I only synced my tabs, which means I've got
> nothing that I can Reset ;-) I don't suppose we can detect this?

I'd say this investigation should be done in bug 616821. Will add a note there.
(Assignee)

Comment 3

6 years ago
Comment on attachment 510061 [details] [diff] [review]
patch [Checkin: comment 3]

http://hg.mozilla.org/comm-central/rev/cc940d2a1b9f
Attachment #510061 - Attachment description: patch → patch [Checkin: comment 3]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
(Assignee)

Updated

6 years ago
No longer blocks: 615950
(Assignee)

Updated

6 years ago
Component: UI Design → Sync UI
QA Contact: ui-design → sync-ui
You need to log in before you can comment on or make changes to this bug.