The default bug view has changed. See this FAQ.

Port |Bug 555547 - A command of placesContextMenu is carried out for a wrong bookmark item| to SeaMonkey

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Bookmarks & History
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b3
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)

Updated

6 years ago
No longer blocks: 467530
(Assignee)

Comment 1

6 years ago
Created attachment 510254 [details] [diff] [review]
(Av1) Just copy application code
[Checked in: Comment 5]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #510254 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 2

6 years ago
Created attachment 510255 [details] [diff] [review]
(Bv1) Copy browser_555547.js, Sort test lists

Bare copy from Firefox, can't succeed as is.
(Assignee)

Comment 3

6 years ago
Created attachment 510256 [details] [diff] [review]
(Cv1-WP1) Adapt browser_555547.js

I tried to adapt this test, but I don't know this code and porting toggleSidebar() seems like a requirement from some other bug (port).

helpwanted to port this test, unless we can just live without it (ftb).
Attachment #510256 - Flags: feedback?(iann_bugzilla)
(Assignee)

Updated

6 years ago
Target Milestone: --- → seamonkey2.1b3

Updated

6 years ago
Attachment #510254 - Flags: review?(iann_bugzilla) → review+

Comment 4

6 years ago
To replace toggleSidebar() you would need something like:
http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js?mark=1239-1247#1239

1239       if (sidebar_is_hidden())
1240         SidebarShowHide();
1241 
1242       if (sidebar_is_collapsed())
1243         SidebarExpandCollapse();
1244 
1245       var searchPanel = document.getElementById("urn:sidebar:panel:search");
1246       if (searchPanel)
1247         SidebarSelectPanel(searchPanel, true, true); // lives in sidebarOverlay.js
(Assignee)

Comment 5

6 years ago
Comment on attachment 510254 [details] [diff] [review]
(Av1) Just copy application code
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/7bda34f6086b
Attachment #510254 - Attachment description: (Av1) Just copy application code → (Av1) Just copy application code [Checked in: Comment 5]
(Assignee)

Updated

6 years ago
blocking-seamonkey2.1: ? → ---
Flags: in-testsuite?
(Assignee)

Comment 6

6 years ago
Let's call this fixed ftb, even though it's still 'in‑testsuite=?'.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
Comment on attachment 510256 [details] [diff] [review]
(Cv1-WP1) Adapt browser_555547.js

This probably needs to wait until Firefox sidebar API is ported to SeaMonkey - if there's not a bug for that already there probably needs to be one.
Attachment #510256 - Flags: feedback?(iann_bugzilla) → feedback-
You need to log in before you can comment on or make changes to this bug.