631900 - Port |Bug 555547 - A command of placesContextMenu is carried out for a wrong bookmark item| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just copy application code [Checked in: Comment 5]

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Copy browser_555547.js, Sort test lists

Bare copy from Firefox, can't succeed as is.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-WP1) Adapt browser_555547.js

I tried to adapt this test, but I don't know this code and porting toggleSidebar() seems like a requirement from some other bug (port).

helpwanted to port this test, unless we can just live without it (ftb).

Comment 4

[Philip Chee]

To replace toggleSidebar() you would need something like:
http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js?mark=1239-1247#1239

1239       if (sidebar_is_hidden())
1240         SidebarShowHide();
1241 
1242       if (sidebar_is_collapsed())
1243         SidebarExpandCollapse();
1244 
1245       var searchPanel = document.getElementById("urn:sidebar:panel:search");
1246       if (searchPanel)
1247         SidebarSelectPanel(searchPanel, true, true); // lives in sidebarOverlay.js

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 510254 [details] [diff] [review]
(Av1) Just copy application code
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/7bda34f6086b

Comment 6

[Serge Gautherie (:sgautherie)]

Let's call this fixed ftb, even though it's still 'in‑testsuite=?'.

Comment 7

[Ian Neal]

Comment on attachment 510256 [details] [diff] [review]
(Cv1-WP1) Adapt browser_555547.js

This probably needs to wait until Firefox sidebar API is ported to SeaMonkey - if there's not a bug for that already there probably needs to be one.