631939 - New SVG list item DOM wrappers get confused if there are more than 256 items in list

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

The mistaken use of PRUint8 in some places means that the new SVG list item DOM wrappers will get confused if there are more than 256 items in the list.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Requesting approval at same time as review. Will add test too.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch with test

This isn't a read/write bad memory issue, but we should probably still get it in.

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to comment #2)
> This isn't a read/write bad memory issue

Well, actually it is, but what I meant is that in this case it isn't an sg issue.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch for checkin

Comment 5

[Jonathan Watt [:jwatt]]

Pushed to try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=a360688c9ea0

Comment 6

[Jonathan Watt [:jwatt]]

The Try orange is due to bug 631939, so this one should be fine.

Comment 7

[Jonathan Watt [:jwatt]]

Pushed to try with fixed patch for bug 631939: http://tbpl.mozilla.org/?tree=MozillaTry&rev=bd7c865af7fa

Comment 8

[Daniel Holbert [:dholbert]]

(Comment 7 meant to say "with fixed patch for *bug 631946*)

Comment 7 passed try-server (after some RelEng woes were resolved in bug
632211).
  --> Adding checkin-needed flag, at jwatt's request.

Comment 9

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/7f6b89af7074

Comment 10

[Jonathan Watt [:jwatt]]

Thanks Jacek!