New SVG list item DOM wrappers get confused if there are more than 256 items in list

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [softblocker])

Attachments

(1 attachment, 2 obsolete attachments)

The mistaken use of PRUint8 in some places means that the new SVG list item DOM wrappers will get confused if there are more than 256 items in the list.
Posted patch patch (obsolete) — Splinter Review
Requesting approval at same time as review. Will add test too.
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #510156 - Flags: review?(roc)
Attachment #510156 - Flags: approval2.0?
Posted patch patch with test (obsolete) — Splinter Review
This isn't a read/write bad memory issue, but we should probably still get it in.
Attachment #510156 - Attachment is obsolete: true
Attachment #510180 - Flags: review?(roc)
Attachment #510180 - Flags: approval2.0?
Attachment #510156 - Flags: review?(roc)
Attachment #510156 - Flags: approval2.0?
(In reply to comment #2)
> This isn't a read/write bad memory issue

Well, actually it is, but what I meant is that in this case it isn't an sg issue.
Attachment #510180 - Flags: review?(roc)
Attachment #510180 - Flags: review+
Attachment #510180 - Flags: approval2.0?
Attachment #510180 - Flags: approval2.0+
Attachment #510180 - Attachment is obsolete: true
The Try orange is due to bug 631939, so this one should be fine.
Version: unspecified → Trunk
(Comment 7 meant to say "with fixed patch for *bug 631946*)

Comment 7 passed try-server (after some RelEng woes were resolved in bug
632211).
  --> Adding checkin-needed flag, at jwatt's request.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7f6b89af7074
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Thanks Jacek!
You need to log in before you can comment on or make changes to this bug.