63194 - Remove unused nsMetaCharsetObserver::Notify

Status: RESOLVED INVALID

(Core :: Internationalization, defect)

Description

[nhottanscp]

Separated from bug 62754.
Please removed unused nsMetaCharsetObserver::Notify.

Comment 1

[Frank Tang]

nhotta, could you include more info into this bug?

Comment 2

[nhottanscp]

It was pointed out by harrshd when he fixed bug 62754.
There are several nsMetaCharsetObserver::Notify but some are not used and should
be removed.
http://lxr.mozilla.org/seamonkey/search?string=nsMetaCharsetObserver%3A%3ANotify

Harrish, do you know which one should be removed?

Comment 3

[Frank Tang]

I think this will help a little bit to reduce footprint. reassign to yokoyama. I
don't think this is that important to spend time now for now. But one byte is
one byte....

Comment 4

[Roy Yokoyama]

Updating the target milestone.

Comment 5

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 6

[Roy Yokoyama]

Harrish, do you know which one should be removed?  

Comment 7

[harishd]

You should probably talk to ftang.

Comment 8

[Frank Tang]

not critical. move to future

Comment 9

[Serge Gautherie (:sgautherie)]

Bug 62754 comment 15:
{{
vidur (gone)   2000-12-18 11:16:20 PDT

The unused nsMetaCharsetObserver::Notify() methods should be
eliminated.
}}

That patch did
{{
-   return Notify((nsISupports*)aDocumentID, &keys, &values);
+   return NS_OK;//Notify((nsISupports*)aDocumentID, &keys, &values);
}}
in <mozilla/htmlparser/src/nsMetaCharsetObserver.cpp>.

But that 3-arg method was still called from another line.

*****

Then, there has been:
{{
96364 - Register html tag observers directly to parser service rather than nsObserverService. Doing so, reduces a lot of overhead. Also, the observers are now notified via sink. This eliminates the need for parser bundle.
r=dp,shanjian,sfraser, sr=rpotts.
}}
<mozilla/intl/chardet/src/nsMetaCharsetObserver.h>
1.8 	harishd%netscape.com	2001-09-28 16:08
<mozilla/intl/chardet/src/nsMetaCharsetObserver.cpp>
1.51	harishd%netscape.com	2001-09-28 16:08

which did
{{
-  NS_IMETHOD Notify(nsISupports* aDocumentID, const nsStringArray* keys, const nsStringArray* values);
+  NS_IMETHOD Notify(nsISupports* aWebShell, 
+                    nsISupports* aChannel,
+                    const nsStringArray* keys, 
+                    const nsStringArray* values);
}}

But did not update the commented out call from bug 62754 patch.

*****

Now (Gecko v1.9.1a2pre), I tried (as a test) to remove the 5 methods, and got:
{{
...\mozilla\intl\chardet\src\nsCharDetConstructors.h (64) :
error C2259: 'nsMetaCharsetObserver' : cannot instantiate abstract class
        due to following members:
        'nsresult nsIElementObserver::Notify(nsISupports *,nsISupports *,const PRUnichar *,const nsStringArray *,const nsStringArray *,const PRUint32)' : is abstract
        ../../../dist/include/htmlparser\nsIElementObserver.h(80) : see declaration of 'nsIElementObserver::Notify'
        'nsresult nsIElementObserver::Notify(PRUint32,const PRUnichar *,PRUint32,const PRUnichar *[],const PRUnichar *[])' : is abstract
        ../../../dist/include/htmlparser\nsIElementObserver.h(76) : see declaration of 'nsIElementObserver::Notify'
        'nsresult nsIElementObserver::Notify(PRUint32,nsHTMLTag,PRUint32,const PRUnichar *[],const PRUnichar *[])' : is abstract
        ../../../dist/include/htmlparser\nsIElementObserver.h(72) : see declaration of 'nsIElementObserver::Notify'
}}

One at a time, I had to readd the 5 methods...

My guesses/questions would be:
*Was this bug "invalid" ?
*Need to remove/document the commented out call !
*Want to remove the whole class ??

Comment 10

[Simon Montagu :smontagu]

I believe this is INVALID