Closed
Bug 631993
Opened 13 years ago
Closed 13 years ago
Remove obsolete static variable that seems to do one-off leaks in unit tests, and some other obsolete member vars in nsImapMailFolder
Categories
(MailNews Core :: Networking: IMAP, defect)
MailNews Core
Networking: IMAP
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a3
People
(Reporter: standard8, Assigned: standard8)
Details
(Keywords: memory-footprint, memory-leak)
Attachments
(1 file, 1 obsolete file)
3.17 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
I was taking a quick look at why some of the IMAP tests were leaking an AtomImpl and nsStringBuffer. With a quick bit of debug, it turned out this was due to the "ImapHdrDownloaded" atom (this being a one-off very small leak). I was just looking at why it was leaking, when I realised that it was completely redundant. Therefore, attached is the patch to remove this redundant static var (which also fixes the leak :-) ).
Attachment #510248 -
Flags: review?(bienvenu)
Assignee | ||
Comment 1•13 years ago
|
||
Wait, I just found some more obsolete member variables...
Summary: Remove obsolete static variable that seems to do one-off leaks in unit tests → Remove obsolete static variable that seems to do one-off leaks in unit tests, and some other obsolete member vars in nsImapMailFolder
Assignee | ||
Comment 2•13 years ago
|
||
I happened to see a suspicious comment, and with a quick bit of searching, found some member variables that were also obsolete (or may have never been used).
Attachment #510248 -
Attachment is obsolete: true
Attachment #510252 -
Flags: review?(bienvenu)
Attachment #510248 -
Flags: review?(bienvenu)
Assignee | ||
Updated•13 years ago
|
Updated•13 years ago
|
Attachment #510252 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/33c7875eb77c
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
You need to log in
before you can comment on or make changes to this bug.
Description
•