Closed Bug 632079 Opened 13 years ago Closed 13 years ago

[Demo Studio] Unique file name for demo ZIP download

Categories

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, enhancement)

x86
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lorchard, Unassigned)

Details

(Whiteboard: qawanted)

All demo ZIP files are currently named "demo_package.zip". This makes it easier to link to demos within the app, and is more secure than allowing a user-supplied filename.

But, it's not great for downloading the source, since multiple downloads would all be named the same. Might be nice to find a safe way to incorporate the demo URL slug in the filename
Target Milestone: --- → 0.9.4
I have already felt the pain of this from downloading demos from different authors... let's try to get the naming to match the slug for 0.9.5.
Target Milestone: 0.9.4 → 0.9.5
https://github.com/fwenzel/mdn/commit/ec539c19a8c2995861c9410337b3564e04fdc90e

Haven't copied this over to kuma yet, will wait to close until then.
This should be working on stage9 now. The filename for zip downloads should include up to 20 characters from the slug for the demo, along with a timestamp and demo_package.

So, for example: hypnofox-2-revenge-o_1303243318_demo_package.zip

It's not perfectly human-readable, but the filename needs to be kept short or else we run into database problems.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: qawanted
Version: MDN → unspecified
Component: Demos → Demo Studio / Dev Derby
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.