Intermittent test_bug629838.html | Got MozAfterPaint event 25 time(s).

RESOLVED FIXED in mozilla6

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philor, Assigned: kael)

Tracking

(Blocks: 1 bug, {intermittent-failure})

Trunk
mozilla6
x86
Mac OS X
intermittent-failure
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Could just be coincidence, but it seems odd that this failed with the same number of events on both mozilla-central and TraceMonkey during the same hour, the hour when everything's busy with nightlies and l10n repacks of them.

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1297078413.1297082164.4830.gz
Rev3 MacOSX Snow Leopard 10.6.2 tracemonkey debug test mochitests-4/5 on 2011/02/07 03:33:33
s: talos-r3-snow-026

1006 INFO TEST-PASS | /tests/layout/base/tests/test_bug629838.html | Background color iteration 46, afterpaint count: 25, mozpaint count: 55
1007 INFO TEST-PASS | /tests/layout/base/tests/test_bug629838.html | mozPaintCount incremented enough from background color changes.
1008 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug629838.html | Got MozAfterPaint event 25 time(s).

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1297078413.1297082164.4830.gz
Rev3 MacOSX Snow Leopard 10.6.2 tracemonkey debug test mochitests-4/5 on 2011/02/07 03:33:33
s: talos-r3-snow-026

1006 INFO TEST-PASS | /tests/layout/base/tests/test_bug629838.html | Background color iteration 46, afterpaint count: 25, mozpaint count: 55
1007 INFO TEST-PASS | /tests/layout/base/tests/test_bug629838.html | mozPaintCount incremented enough from background color changes.
1008 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug629838.html | Got MozAfterPaint event 25 time(s).
(Assignee)

Comment 1

6 years ago
I suspected that
Assignee: nobody → kevin.gadd
(Assignee)

Comment 2

6 years ago
Doh, pressed enter by accident. Anyway, I suspected that this test might be vulnerable to machine load. I could try and fix it by adjusting the constants, but I think it's probably just better to fall back on merely testing that we get enough afterpaint events 'eventually', and drop the strict timing requirements since they seem to be unreliable.
(Assignee)

Comment 3

6 years ago
Created attachment 512595 [details] [diff] [review]
No longer assert that MozAfterPaint fires in sync with mozPaintCount increases.

I've attached a patch that changes the assertions in this test so that it merely requires MozAfterPaint to fire a certain number of times eventually, instead of asserting that it fires in sync with mozPaintCount increases. This should be reliable, even if it lets later breakages through.
Attachment #512595 - Flags: review?
(Assignee)

Updated

6 years ago
Whiteboard: [orange] → [orange][needs-review]
Comment hidden (Treeherder Robot)

Comment 5

6 years ago
Comment on attachment 512595 [details] [diff] [review]
No longer assert that MozAfterPaint fires in sync with mozPaintCount increases.

Kevin, you should ask someone to review the patch.
Comment on attachment 512595 [details] [diff] [review]
No longer assert that MozAfterPaint fires in sync with mozPaintCount increases.

I think roc can review this.
Attachment #512595 - Flags: review? → review?(roc)
Blocks: 648353
Comment on attachment 512595 [details] [diff] [review]
No longer assert that MozAfterPaint fires in sync with mozPaintCount increases.

Review of attachment 512595 [details] [diff] [review]:
Attachment #512595 - Flags: review?(roc) → review+
Thanks Kevin for your patch.  Guys, can one of you please land this?
Keywords: checkin-needed
Whiteboard: [orange][needs-review] → [orange]
Keywords: checkin-needed
Whiteboard: [orange] → [fixed in cedar]
Pushed:
https://bugzilla.mozilla.org/show_bug.cgi?id=632102
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
Whiteboard: [orange]
http://hg.mozilla.org/projects/cedar/rev/28b52c3fd694
http://hg.mozilla.org/mozilla-central/rev/28b52c3fd694
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.