632170 - Downloaded files should be saved in a public place

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Bug 622684 changed the method used for finding the downloads directory to use new APIs available in SDK 8 and greater. We're now calling getExternalFilesDir(Environment.DIRECTORY_DOWNLOADS) which returns something like:

/Android/data/<package_name>/files/Download

instead we can use the public downloads directory, recommended for "shared" files by http://developer.android.com/guide/topics/data/data-storage.html#filesExternal by using:

getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS)

which may even make things like images show up in the gallery again?.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

is it possible to continue to download our updates to the private location?

Comment 3

[Wesley Johnston (:wesj)]

Yeah. We'd probably need a separate environmental variable, and then an update to mobile browser at:

http://mxr.mozilla.org/mobile-browser/source/components/DirectoryProvider.js#77

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Mobile-browser v1

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 510708 [details] [diff] [review]
Patch v2

Removing review request till I've had a chance to test these. Sorry :(

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Mobile-browser v1.1

Returns the directory given by the environmental variable "UPDATES_DIRECTORY" if it exists, otherwise uses the downloads directory.

Note, updates are actually stored in this path + "/updates/".

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 510708 [details] [diff] [review]
Patch v2

These return the correct directory for me on desktop and device. Not sure how you test actual updates...

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510838 [details] [diff] [review]
Mobile-browser v1.1

Do we care if the localFile exists or not? We could check that too.

r+, but think about the check - we might not need it if we are being given the value in Java.

Comment 10

[Wesley Johnston (:wesj)]

pushed:
mc: http://hg.mozilla.org/mozilla-central/rev/8728536ebec3
mb: http://hg.mozilla.org/mobile-browser/rev/da356a8d0644

Comment 11

[Anna (Waverley)]

VERIFIED FIXED on:
Build Id:
Mozilla /5.0 (Android;Linux armv7l;rv:2.0b12pre) Gecko/20110210
Firefox/4.0b12pre Fennec /4.0b5pre 

Device: Motorola Droid 2 (Android 2.2)