XULBrowserWindow.onLocationChange looks for a "disablefastfind" attribute in all content documents before ruling them out because their URI scheme isn't "about" or "chrome"

RESOLVED FIXED in Firefox 12

Status

()

Firefox
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)

Comment 1

7 years ago
My patch in bug 569342 performs the checks in a different order, so Gavin must have commented on it IRL, but I forget what the reasoning behind the change was.
Why does this matter? I wouldn't expect there to be a significant difference between docElt.getAttribute vs. the two schemeIs calls.
(Assignee)

Comment 3

6 years ago
Created attachment 585284 [details] [diff] [review]
patch

The discussion in bug 384412 reminded me of this again. Even if it may end up not mattering, we should, on principle, access content as late as possible.
Attachment #585284 - Flags: review?(gavin.sharp)
Attachment #585284 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/dd994bf80fc0
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/dd994bf80fc0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.