Remove NS_NOTREACHED occurrences near nsCacheEntryDescriptor.cpp:686

RESOLVED FIXED in mozilla2.0b12

Status

()

Core
Networking: Cache
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Sean Dunn, Assigned: Sean Dunn)

Tracking

unspecified
mozilla2.0b12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
2.14 KB, patch
khuey
: review+
Benjamin Smedberg
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
This assert is causing a debug popup for Panorama when calling NetUtil.asyncCopy() and is blocking Panorama bug 604699.

File:
http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/nsCacheEntryDescriptor.cpp#686

Background conversation:
[20:33] <khuey|away> the async copy code probes WriteSegments to see if the stream is buffered
[20:33] <khuey|away> so asserting that the method is never called is silly
[20:34] <khuey|away> asserting that xpcom interface methods are never called is silly in general
(Assignee)

Updated

7 years ago
Blocks: 604699
Component: General → Networking: Cache
Product: Firefox → Core
QA Contact: general → networking.cache
(Assignee)

Comment 1

7 years ago
Created attachment 510505 [details] [diff] [review]
v1
Assignee: nobody → seanedunn
Status: NEW → ASSIGNED
Attachment #510505 - Flags: review?(bzbarsky)
Attachment #510505 - Flags: feedback?(khuey)
Attachment #510505 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

7 years ago
Created attachment 510844 [details] [diff] [review]
v2

Found additional asserts in nsStorageStream which are blocking the async implementation of bug 604699.
Attachment #510505 - Attachment is obsolete: true
Attachment #510844 - Flags: review?
(Assignee)

Updated

7 years ago
Depends on: 628701
Attachment #510844 - Flags: approval2.0?

Updated

7 years ago
Attachment #510844 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 4

7 years ago
Try passed.
(Assignee)

Updated

7 years ago
No longer depends on: 628701

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/ee6b0aab1d3f
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
(Assignee)

Updated

7 years ago
Depends on: 602432
(Assignee)

Updated

7 years ago
No longer depends on: 602432
You need to log in before you can comment on or make changes to this bug.