Closed Bug 632280 Opened 13 years ago Closed 13 years ago

Remove NS_NOTREACHED occurrences near nsCacheEntryDescriptor.cpp:686

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: seanedunn, Assigned: seanedunn)

References

Details

Attachments

(1 file, 1 obsolete file)

v2
2.14 KB, patch
khuey
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review 
This assert is causing a debug popup for Panorama when calling NetUtil.asyncCopy() and is blocking Panorama bug 604699.

File:
http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/nsCacheEntryDescriptor.cpp#686

Background conversation:
[20:33] <khuey|away> the async copy code probes WriteSegments to see if the stream is buffered
[20:33] <khuey|away> so asserting that the method is never called is silly
[20:34] <khuey|away> asserting that xpcom interface methods are never called is silly in general
Blocks: 604699
Component: General → Networking: Cache
Product: Firefox → Core
QA Contact: general → networking.cache
Attached patch v1 (obsolete) — — Splinter Review 
Assignee: nobody → seanedunn
Status: NEW → ASSIGNED

        Attachment #510505 -
        Flags: review?(bzbarsky)

        Attachment #510505 -
        Flags: feedback?(khuey)

        Attachment #510505 -
        Flags: review?(bzbarsky) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2
        — 
          — Splinter Review
      

    


  
Found additional asserts in nsStorageStream which are blocking the async implementation of bug 604699.

        Attachment #510505 -
        Attachment is obsolete: true

        Attachment #510844 -
        Flags: review?

    
  
Depends on: 628701

    
  

        Attachment #510844 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
Try passed.

    
  
No longer depends on: 628701

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/ee6b0aab1d3f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12

    
  
Depends on: 602432

    
  
No longer depends on: 602432

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: