Closed Bug 632290 Opened 9 years ago Closed 2 years ago

Intermittent browser_about.js | Test timed out | Found unexpected add-ons manager window still open

Categories

(Toolkit :: Add-ons Manager, defect, P3)

x86
Windows 7
defect

Tracking

()

RESOLVED INACTIVE
Tracking Status
firefox37 --- disabled
firefox38 --- disabled
firefox39 --- disabled

People

(Reporter: philor, Assigned: RyanVM)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on Linux and Windows])

Attachments

(3 files, 1 obsolete file)

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297136072.1297137836.19702.gz
Rev3 WINNT 6.1 mozilla-central opt test mochitest-other on 2011/02/07 19:34:32
s: talos-r3-w7-028

TEST-PASS | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_about.js | Should be closing window with correct URI
TEST-INFO | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_about.js | Longer timeout required, waiting longer...  Remaining timeouts: 1
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_about.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_about.js | Found unexpected add-ons manager window still open
INFO TEST-END | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_about.js | finished in 60053ms
Attached patch tentative patchSplinter Review
Dave, is there a specific reason this test is using waitForFocus in the domwindowopen handler? locally I see this test perma failing, while with a simple load event it works fine.
I also see a globalwindow assertion, but it disappears with the fix for bug 651315, since this uses openDialog could be related.
Attachment #527898 - Flags: review?(dtownsend)
(In reply to comment #63)
> Created attachment 527898 [details] [diff] [review]
> tentative patch
> 
> Dave, is there a specific reason this test is using waitForFocus in the
> domwindowopen handler? locally I see this test perma failing, while with a
> simple load event it works fine.
> I also see a globalwindow assertion, but it disappears with the fix for bug
> 651315, since this uses openDialog could be related.

When we first landed it in bug 610661 we found it failed with just a load handler.
I've also very commonly seen issues when attempting to close windows that have only just opened but haven't fully got focus on linux so I'm not sure I'd want to take this. Why would it be failing for you with waiting for focus?
Comment on attachment 527898 [details] [diff] [review]
tentative patch

Review of attachment 527898 [details] [diff] [review]:

This is something that I'd only expect to make things worse unless waitForFocus is broken in some way, so I don't think we should take it.
Attachment #527898 - Flags: review?(dtownsend) → review-
(In reply to comment #65)
> I've also very commonly seen issues when attempting to close windows that have
> only just opened but haven't fully got focus on linux so I'm not sure I'd want
> to take this. Why would it be failing for you with waiting for focus?

I don't know, but I was able to reproduce failures constantly and this bug demonstrates that something is broken.  FWIW bug 521233 is still open.
Something interesting I found is that this test always asserts, see bug 511467 comment 4. A workaround to the assertion is to enqueue the aManagerWindow.close() call in close_manager, so that the docshell is destroyed after the modal dialog dismissal is completely handled. I have no idea if there is a relation with the missing "unload" event though :(
Summary: Intermittent browser_about.js | Test timed out → Intermittent browser_about.js | Test timed out | Found unexpected add-ons manager window still open
On 5/14, this morphed to "Intermittent browser_about.js | Test timed out | Found a tab after previous test timed out: about:addons".  I don't know if the subject should be changed or a new bug should be filed...