632314 - Ephemeral stack frames do not get cleaned up

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

When turning off debugging (now in jsdService::Deactivate called by jsdService::Off, until recently directly in jsdService::Off), almost all ephemeral objects are invalidated:

    jsdContext::InvalidateAll();
    jsdScript::InvalidateAll();
    jsdValue::InvalidateAll();
    jsdProperty::InvalidateAll();

notably missing is jsdStackFrame::InvalidateAll(). I see no reason for the omission, and I ran into a crash when using a stack frame from a dead JSDContext. I seem to crash a bit less if I invalidate those stack frames too, which admittedly isn't a very sound argument, but I think I'm running into crashes for multiple other reasons, so it's hard to tell what's what.

Vague STR: install the latest Firebug 1.7 and FBTest 1.7. Run it. Crash.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Invalidate jsdStackFrames when deactivating debugging

Invalidate jsdStackFrames when the rest of the ephemerals get invalidated.

Comment 2

[timeless]

Comment on attachment 510520 [details] [diff] [review]
Invalidate jsdStackFrames when deactivating debugging

i'll buy that.

historically there are some shutdown things which intentionally leak, but this isn't that. i think that the off + on again path is probably relatively untested / historically unused.

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/tracemonkey/rev/7f471033a507

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/7f471033a507