632346 - Opening a new tab should hide the right panel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This bug assume Fennec is selected as the default browser 

Steps to reproduce:
 * go to the right panel
 * quit fennec by tapping the home button
 * click on a web link on any app of the system

Actual result:
 * Fennec show up but with the right panel into view

Expected result: 
 * Fennec show up and the main view with the opened url is displayed

I would like to have Madhava's input on this.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510559 [details] [diff] [review]
Patch

I don't like the location for this code. calling hidePanel on every TabOpen seems overkill. Let's be more explicit here. I assume we are being opened from the commandline. Also, we might be getting into the nsBrowserAccess code to create a new tab. Let's try using that code to call hidePanel

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Is it what you're looking for?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510589 [details] [diff] [review]
Patch v0.2

No. Browser.startup should never be called more than once in a running instance of Fennec and if it is called, the panel should already be hidden.

I was talking about this code:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#1422

see if this code is executed when the new tab is being oepned.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.3

shame...

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510592 [details] [diff] [review]
Patch v0.3

That's it

Comment 6

[Madhava Enros [:madhava]]

Yes, agreed - we should open with the main view in.. uh, view.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/481c111fc4f4

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre Fennec/4.0b5pre

Comment 9

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15209

Comment 10

[Dão Gottwald [:dao]]

bugspam