Closed Bug 632346 Opened 9 years ago Closed 9 years ago
Opening a new tab should hide the right panel
This bug assume Fennec is selected as the default browser Steps to reproduce: * go to the right panel * quit fennec by tapping the home button * click on a web link on any app of the system Actual result: * Fennec show up but with the right panel into view Expected result: * Fennec show up and the main view with the opened url is displayed I would like to have Madhava's input on this.
Attachment #510559 - Flags: review?(mark.finkle)
Comment on attachment 510559 [details] [diff] [review] Patch I don't like the location for this code. calling hidePanel on every TabOpen seems overkill. Let's be more explicit here. I assume we are being opened from the commandline. Also, we might be getting into the nsBrowserAccess code to create a new tab. Let's try using that code to call hidePanel
Attachment #510559 - Flags: review?(mark.finkle) → review-
Is it what you're looking for?
Comment on attachment 510589 [details] [diff] [review] Patch v0.2 No. Browser.startup should never be called more than once in a running instance of Fennec and if it is called, the panel should already be hidden. I was talking about this code: http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#1422 see if this code is executed when the new tab is being oepned.
Attachment #510589 - Flags: review?(mark.finkle) → review-
Comment on attachment 510592 [details] [diff] [review] Patch v0.3 That's it
Attachment #510592 - Flags: review?(mark.finkle) → review+
Yes, agreed - we should open with the main view in.. uh, view.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on build: Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre Fennec/4.0b5pre
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.