632412 - regression in partner repack signing

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Since bug 614227 we're unable to properly sign win32 EU Ballot builds, because their filepath doesn't match this regex:
http://hg.mozilla.org/build/tools/file/878c613c80bf/release/signing/signing.py#l79

Comment 1

[[e-mail] (:bhearsum)]

Attachment: probable fix

Still testing this, but it looks like it's going to work.

In my original patches, I changed the Makefile in such a way that we copied the win32-EUBallot directory over to signed-buildN *prior* to running signcode. Because of this, I didn't realize that I needed to update fileInfo(), too. This patch corrects both of those areas.

I'll poke someone for review once I confirm it in my testrun.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: fix ballot signing, tested

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 510688 [details] [diff] [review]
fix ballot signing, tested

Landed this, and moved the FIREFOX_3_6_14_BUILD2 and _RELEASE tags to it. Leaving this bug open so I can update the tests.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: update signing tests

I added two new tests: one for EUBallot, one for partner repacks, and I also split up the massive fileInfo test into individual ones, to make sure they all run even if one fails.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 510757 [details] [diff] [review]
update signing tests

Landed this.

Doing a final re-run of 3.6.14build2 in staging before I declare this FIXED.

Comment 6

[[e-mail] (:bhearsum)]

(In reply to comment #5)
> Comment on attachment 510757 [details] [diff] [review]
> update signing tests
> 
> Landed this.
> 
> Doing a final re-run of 3.6.14build2 in staging before I declare this FIXED.

Done and passed!