Closed Bug 632469 Opened 14 years ago Closed 14 years ago

Handle non-finite values for clearRect per spec

Categories

(Core :: Graphics: Canvas2D, defect)

Product:
Core
Component:
Graphics: Canvas2D
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Keywords: dev-doc-complete, html5)

Attachments

(1 file, 1 obsolete file)

Patch for checkin
1.43 KB, patch
Details | Diff | Splinter Review
Attached patch Patch v1 (obsolete) — — Splinter Review 
      No description provided.
Flags: in-testsuite+
Attachment #510676 - Flags: review?(Olli.Pettay)
Comment on attachment 510676 [details] [diff] [review]
Patch v1

So why doesn't .clearRect throw?
Seems like canvas API is all but consistent when to throw and when not.
I apparently was wrong before. The spec silently ignores all non-finite arguments, except when creating CanvasGradient and ImageData objects, and it throws for negative radii, which, I suppose, would be caused by a bogus calculation.
Attachment #510676 - Flags: review?(Olli.Pettay) → review+
Depends on: post2.0
Whiteboard: [needs landing]
Keywords: checkin-needed
Whiteboard: [needs landing]

        Attachment #510676 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/69bd065b7fa8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
No longer depends on: post2.0
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: