632615 - add tweet this button to thanks page

Status: VERIFIED FIXED

(Input Graveyard :: Submission, enhancement, P1)

Description

[Aakash Desai [:aakashd]]

It'd be great for beta testers to seek help/support via their feedback sent in by linking to the army-of-awesome twitter account. Expect some requirements and such in the future after William and I talk about benefits, costs and upkeep.

Comment 2

[William Reynolds [:williamr]]

Aakash, could you summarize the requirements for this bug? It's been a while since we discussed it so I could use a refresher. Happy to talk in person as well. Thanks!

Comment 3

[Aakash Desai [:aakashd]]

Yeah, here they are:

Context:
* Add the following text to the top of the list of follow-up items on the thanks page:

Want to share your feedback to your followers?

<a href="tweet this link">Tweet your message about Firefox!</a>


Functionality:
* On click, the same functionality (i.e. pop-up dialog with all or part of the feedback, bit.ly link and #fxinput hash tag) as the one on Input's dashboard is shown to a user and allows them to tweet the message via their twitter account.
* After submission, the dialog should close (same behavior).



If you or Matt have any questions, please feel free to ask.

Comment 4

[tofumatt [:tofumatt]]

We'll need to prevent the thanks page from caching if we are going to add the text to send to twitter needed to make this work. Each thanks page would have custom-tailored text that would go into the tweet link based on the user's submitted opinion.

(We'd also need to save that opinion as flash session data to carry over, but that's no biggie.)

Is that cool with everyone? The thanks page is heavily hit and probably benefits from the caching a lot, though it'd be nice to have the actual feedback in the tweet instead of an "I just submitted feedback." type of tweet.

Comment 5

[tofumatt [:tofumatt]]

So the start of this is here, but it's no longer cached. Varying on cookie won't help because the feedback of a user can change multiple times throughout their session.

But this is what it would look like: https://github.com/tofumatt/reporter/commit/b9548624cc7d2bbcf590777b5b2cc1ae8bc0f75c

r?

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

tofumatt,

How about on submission we redirect them the opinion page, but decorate it specially so it says "thanks for your submission"

Tweet this, can be a part of every single opinion page, because i know Aakash, I and others would love to tweet the funnier input messages ;)

Comment 7

[Aakash Desai [:aakashd]]

Dave, that's a good idea and something we should discuss in the status meeting on Tuesday. That way, we can set up something like that in the future! 

For now, getting this out in its current way will allow a way for our army of awesome, engagement and development teams to be able to have a two-way piece of communication with folks in the Firefox 5 time frame.

Comment 8

[tofumatt [:tofumatt]]

This would mean ditching the "Thanks" page entirely and instead decorating the opinion page with most of the stuff from the "Thanks" page, right?

I like the thanks page a lot and it encourages users to give more feedback. Maybe we even want a "see my opinion" on that page (and tell them they can share it from there?)

Comment 9

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Matt, go ahead and keep the thanks page for now.

Comment 10

[tofumatt [:tofumatt]]

"Tweet this" added to the thanks page; r+ from davedash.

Commit: https://github.com/fwenzel/reporter/commit/642d6cce1d8017ae7b875c8da8396a5504322a3a

Comment 11

[Matt Brandt [:mbrandt]]

Hmm ... this appears to be caching the first message (happy, sad, idea) that is tweeted. Submitting additional feedback and then tweeting that feedback results in the first message being what is passed to twitter.

Steps to reproduce:
1. submit feedback (happy/sad/idea)
2. choose "tweet feedback to your followers"
3. after tweeting ... select "submit more feedback"
4. submit feedback again.
5. select tweet the feedback... and notice what gets tweeted.

Comment 12

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

tofumatt,

Turn off the heavy caching on that view, and that should help.

Additionally this is URL based so we could also redirect them to

/opinion/:opinion_id/thanks

Comment 13

[tofumatt [:tofumatt]]

The thanks page is pretty transitory; adding a permanent URL to each opinion's thanks page seems odd. The resource is about thanking you for feedback, but it's not a page you'd want to revisit.

With that in mind, I added @never_cache to the thanks page. There was no explicit caching on the page (and locally it doesn't cache) so I didn't cache this 'til it was on stage.

Can QA verify this doesn't cause the caching issue anymore?

(Commit here: https://github.com/fwenzel/reporter/commit/94bf7a9644f1e160eecfe2bed21ed17e9c35a5ca)

Comment 14

[Matt Brandt [:mbrandt]]

thx for the quick patch tofumatt... qa verified multiple feedback/tweets work splendidly now.