632717 - Limit the total number of results that a search can ever return

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P1)

Description

[Max Kanat-Alexander]

One frequently-reported problem is that you can do searches that return so many bugs that the search never actually completes.

The simplest solution to this is to set a maximum upper bound for how many results a search can return.

I'm going to do some testing to see how quickly Bugzilla returns certain numbers of results (to see where a timeout would start happening) but I suspect a safe value for this would be 10,000 or 20,000 results.

Comment 1

[Frédéric Buclin]

dupe of bug 535571?

Comment 2

[Max Kanat-Alexander]

(In reply to comment #1)
> dupe of bug 535571?

  Ah, no, not quite. This bug here specifies a hard limit that will always be in place, that other bug just allows Search.pm to understand "limit" and "offset" instead of those being set manually in buglist.cgi.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

I've tested this and it works.

LpSolit: This adds a new parameter, but it's a search-related parameter, so I feel that it falls within my Search.pm ownership. If you have some better suggestion around the parameter, though, I'm totally happy to make an adjustment to this patch after checkin.

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified report.cgi
modified Bugzilla/Search.pm
modified Bugzilla/Config/Query.pm
modified template/en/default/admin/params/query.html.tmpl
Committed revision 7722.

Comment 5

[Frédéric Buclin]

(In reply to comment #3)
> LpSolit: This adds a new parameter, but it's a search-related parameter, so I
> feel that it falls within my Search.pm ownership.

I wouldn't say that adding or removing a parameter falls within anyone's ownership. But I looked at your patch and I'm fine with it.