Last Comment Bug 632804 - Port |Bug 588817 - Using "Bookmark all tabs" initially mislabels new folder menuitem in Bookmarks menu| to SeaMonkey
: Port |Bug 588817 - Using "Bookmark all tabs" initially mislabels new folder m...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Serge Gautherie (:sgautherie)
:
:
Mentors:
Depends on: 588817
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-09 06:59 PST by Serge Gautherie (:sgautherie)
Modified: 2011-02-21 17:12 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Just copy it [Checked in: Comment 4] (1.21 KB, patch)
2011-02-09 07:02 PST, Serge Gautherie (:sgautherie)
iann_bugzilla: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-02-09 06:59:11 PST

    
Comment 1 Serge Gautherie (:sgautherie) 2011-02-09 07:02:35 PST
Created attachment 511028 [details] [diff] [review]
(Av1) Just copy it
[Checked in: Comment 4]
Comment 2 Ian Neal 2011-02-12 08:31:25 PST
(In reply to comment #1)
> Created attachment 511028 [details] [diff] [review]
> (Av1) Just copy it

I cannot actually see the problem so do we really need this fix?
Comment 3 Serge Gautherie (:sgautherie) 2011-02-21 15:05:38 PST
(In reply to comment #2)
> I cannot actually see the problem so do we really need this fix?

I don't know about the symptom (which might depend on some other sync' not yet done or whatever): this is a blind sync' from FF, not even trying to add the (updated) test to SeaMonkey.
I assumed we would want to keep "places" code in sync' as much as possible.

Fwiw (but that may not be relevant), all the other "label" in this file use setAttribute().
Comment 4 Serge Gautherie (:sgautherie) 2011-02-21 17:11:53 PST
Comment on attachment 511028 [details] [diff] [review]
(Av1) Just copy it
[Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/65bd1707d181

Note You need to log in before you can comment on or make changes to this bug.