632900 - Disable NetworkGeolocationProvider on Android.

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Android has their own geolocation location provider.  We should not duplicate efforts.

Comment 1

[Josh Matthews [:jdm]]

Fennec is the only app that has working geolocation on my stock 2.1 galaxy s.  The GPS sucking is a well-known issue; dunno if that's something we want to take into consideration.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Doug Turner (:dougt)]

Josh, oh. hmm. can you try my patch, and see if gps still works.  It would suck very much if we needed this on the Galaxy S***.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 511092 [details] [diff] [review]
patch v.1

>diff --git a/dom/system/Makefile.in b/dom/system/Makefile.in
>--- a/dom/system/Makefile.in
>+++ b/dom/system/Makefile.in
>@@ -57,29 +57,33 @@ ifneq (,$(filter cocoa,$(MOZ_WIDGET_TOOL
> DIRS = cocoa
> endif
> 
> ifneq (,$(filter android,$(MOZ_WIDGET_TOOLKIT)))
> DIRS = android
> endif
> 
> CPPSRCS     = \
>-    nsAccelerometer.cpp \
>-    $(NULL)
>+  nsAccelerometer.cpp \
>+  $(NULL)
> 
>+# On Systems that have build in geolocation providers,
>+# we really do not need these.

"built-in".

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

based on Josh's comment, would it be better to still build our own and pref it off?

Comment 6

[Doug Turner (:dougt)]

not really - the wifi scanning code isn't implemented on android.  the best jdm will ever see via our network location provider is a geoip.

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/d429b038ccea

Comment 8

[Doug Turner (:dougt)]

the built in geolocation provider does not provide civic addresses yet.  I think we want to fix that, but in the mean time, lets not stop sending civic addresses when possible.  I filled bug 636344 to figure this out.  When that is fixed, i think we can reland.

Comment 9

[Doug Turner (:dougt)]

backout: http://hg.mozilla.org/mozilla-central/rev/ad46dba4f7e6

Comment 10

[Joe Drew (not getting mail)]

Comment on attachment 511092 [details] [diff] [review]
patch v.1

Backed out, hence no longer approved

Comment 11

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/995bf49d8c54

Comment 12

[Josh Matthews [:jdm]]

I tested this on my Galaxy S today; I no longer get successful geolocation results in Fennec as far as I can tell.

Comment 13

[Doug Turner (:dougt)]

on android, we use whatever is default.  so, if your device doesn't return a location information, firefox/fennec will not be able to see any location data.