Closed Bug 632900 Opened 9 years ago Closed 9 years ago

Disable NetworkGeolocationProvider on Android.

Categories

(Core :: DOM: Geolocation, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

References

Details

(Whiteboard: [land-fennec-4.1?])

Attachments

(1 file)

Android has their own geolocation location provider.  We should not duplicate efforts.
Fennec is the only app that has working geolocation on my stock 2.1 galaxy s.  The GPS sucking is a well-known issue; dunno if that's something we want to take into consideration.
Attached patch patch v.1Splinter Review
Attachment #511092 - Flags: review?(ted.mielczarek)
Josh, oh. hmm. can you try my patch, and see if gps still works.  It would suck very much if we needed this on the Galaxy S***.
Comment on attachment 511092 [details] [diff] [review]
patch v.1

>diff --git a/dom/system/Makefile.in b/dom/system/Makefile.in
>--- a/dom/system/Makefile.in
>+++ b/dom/system/Makefile.in
>@@ -57,29 +57,33 @@ ifneq (,$(filter cocoa,$(MOZ_WIDGET_TOOL
> DIRS = cocoa
> endif
> 
> ifneq (,$(filter android,$(MOZ_WIDGET_TOOLKIT)))
> DIRS = android
> endif
> 
> CPPSRCS     = \
>-    nsAccelerometer.cpp \
>-    $(NULL)
>+  nsAccelerometer.cpp \
>+  $(NULL)
> 
>+# On Systems that have build in geolocation providers,
>+# we really do not need these.

"built-in".
Attachment #511092 - Flags: review?(ted.mielczarek) → review+
based on Josh's comment, would it be better to still build our own and pref it off?
not really - the wifi scanning code isn't implemented on android.  the best jdm will ever see via our network location provider is a geoip.
http://hg.mozilla.org/mozilla-central/rev/d429b038ccea
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
the built in geolocation provider does not provide civic addresses yet.  I think we want to fix that, but in the mean time, lets not stop sending civic addresses when possible.  I filled bug 636344 to figure this out.  When that is fixed, i think we can reland.
Status: RESOLVED → REOPENED
Depends on: 636344
Resolution: FIXED → ---
Comment on attachment 511092 [details] [diff] [review]
patch v.1

Backed out, hence no longer approved
Attachment #511092 - Flags: approval2.0+ → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/995bf49d8c54
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [land-fennec-4.1?]
I tested this on my Galaxy S today; I no longer get successful geolocation results in Fennec as far as I can tell.
on android, we use whatever is default.  so, if your device doesn't return a location information, firefox/fennec will not be able to see any location data.
You need to log in before you can comment on or make changes to this bug.