632904 - Editor/IME/spellcheck use content states when they mean IsEditable()

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Patch coming up per discussion with Ehsan.

Comment 1

[Boris Zbarsky [:bzbarsky]]

In particular, checking for the MOZ_READONLY state is exactly equivalent to checking for |IsEditable() || (some sort of text input the user can type in)|.  It's not clear why we'd ever want to handle those two cases in the same way.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Check IsEditable(), not content states, if we care about editability.

Comment 3

[Peter Van der Beken [:peterv]]

Doesn't this disable spellchecking for xul:textbox and xul:textarea? Or for some XTF elements (nsXTFElementWrapper has a SetIntrinsicState)?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Tthe key part here for spellchecking is the test for _text_ nodes, not elements as far as I can tell.  And for text nodes IntrinsicState() looks like this:

773   return IsEditable() ? NS_EVENT_STATE_MOZ_READWRITE :
774                         NS_EVENT_STATE_MOZ_READONLY;

If you prefer we could back this out and replace with a patch that checks IsEditable() on text nodes and the state on elements; the key part for me is that state is not going to exist on text nodes...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/cb3e118dda44