632907 - Use Element more in the frame constructor

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

This will make some other things I'm working on simpler, and is the right thing to do anyway, imo.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Use Element more in the frame constructor.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 511098 [details] [diff] [review]
Use Element more in the frame constructor.

>diff --git a/layout/base/nsCSSFrameConstructor.cpp b/layout/base/nsCSSFrameConstructor.cpp
>--- a/layout/base/nsCSSFrameConstructor.cpp
>+++ b/layout/base/nsCSSFrameConstructor.cpp
>@@ -3520,19 +3520,19 @@ nsCSSFrameConstructor::FindHTMLData(nsIC
>                  nsCSSAnonBoxes::fieldsetContent ||
>                aParentFrame->GetParent()->GetType() == nsGkAtoms::fieldSetFrame,
>                "Unexpected parent for fieldset content anon box");
>   if (aTag == nsGkAtoms::legend &&
>       (!aParentFrame ||
>        (aParentFrame->GetType() != nsGkAtoms::fieldSetFrame &&
>         aParentFrame->GetStyleContext()->GetPseudo() !=
>           nsCSSAnonBoxes::fieldsetContent) ||
>-       !aContent->GetParent() ||
>-       !aContent->GetParent()->IsHTML() ||
>-       aContent->GetParent()->Tag() != nsGkAtoms::fieldset ||
>+       !aElement->GetParent() ||
>+       !aElement->GetParent()->IsHTML() ||
>+       aElement->GetParent()->Tag() != nsGkAtoms::fieldset ||

Looks like this could be !aElement->GetParent()->IsHTML(nsGkAtoms::fieldset) too

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, sure.  I was more or less on autopilot for the search-and-replace there... ;)  I'll make that change.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/projects/birch/rev/7fc81c0d7e4d

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/7fc81c0d7e4d