Closed Bug 632907 Opened 9 years ago Closed 9 years ago

Use Element more in the frame constructor

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Use Element more in the frame constructor.
40.57 KB, patch
roc
: review+
Details | Diff | Splinter Review 
This will make some other things I'm working on simpler, and is the right thing to do anyway, imo.
Blocks: 598833
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [need review] → [need gk2 ship]
Comment on attachment 511098 [details] [diff] [review]
Use Element more in the frame constructor.

>diff --git a/layout/base/nsCSSFrameConstructor.cpp b/layout/base/nsCSSFrameConstructor.cpp
>--- a/layout/base/nsCSSFrameConstructor.cpp
>+++ b/layout/base/nsCSSFrameConstructor.cpp
>@@ -3520,19 +3520,19 @@ nsCSSFrameConstructor::FindHTMLData(nsIC
>                  nsCSSAnonBoxes::fieldsetContent ||
>                aParentFrame->GetParent()->GetType() == nsGkAtoms::fieldSetFrame,
>                "Unexpected parent for fieldset content anon box");
>   if (aTag == nsGkAtoms::legend &&
>       (!aParentFrame ||
>        (aParentFrame->GetType() != nsGkAtoms::fieldSetFrame &&
>         aParentFrame->GetStyleContext()->GetPseudo() !=
>           nsCSSAnonBoxes::fieldsetContent) ||
>-       !aContent->GetParent() ||
>-       !aContent->GetParent()->IsHTML() ||
>-       aContent->GetParent()->Tag() != nsGkAtoms::fieldset ||
>+       !aElement->GetParent() ||
>+       !aElement->GetParent()->IsHTML() ||
>+       aElement->GetParent()->Tag() != nsGkAtoms::fieldset ||

Looks like this could be !aElement->GetParent()->IsHTML(nsGkAtoms::fieldset) too
Yeah, sure.  I was more or less on autopilot for the search-and-replace there... ;)  I'll make that change.
http://hg.mozilla.org/projects/birch/rev/7fc81c0d7e4d
Whiteboard: [need gk2 ship] → fixed-in-birch
https://hg.mozilla.org/mozilla-central/rev/7fc81c0d7e4d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.