Closed
Bug 632907
Opened 14 years ago
Closed 14 years ago
Use Element more in the frame constructor
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
40.57 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This will make some other things I'm working on simpler, and is the right thing to do anyway, imo.
![]() |
Assignee | |
Comment 1•14 years ago
|
||
Attachment #511098 -
Flags: review?(roc)
Updated•14 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Attachment #511098 -
Flags: review?(roc) → review+
![]() |
Assignee | |
Updated•14 years ago
|
Whiteboard: [need review] → [need gk2 ship]
Comment 2•14 years ago
|
||
Comment on attachment 511098 [details] [diff] [review]
Use Element more in the frame constructor.
>diff --git a/layout/base/nsCSSFrameConstructor.cpp b/layout/base/nsCSSFrameConstructor.cpp
>--- a/layout/base/nsCSSFrameConstructor.cpp
>+++ b/layout/base/nsCSSFrameConstructor.cpp
>@@ -3520,19 +3520,19 @@ nsCSSFrameConstructor::FindHTMLData(nsIC
> nsCSSAnonBoxes::fieldsetContent ||
> aParentFrame->GetParent()->GetType() == nsGkAtoms::fieldSetFrame,
> "Unexpected parent for fieldset content anon box");
> if (aTag == nsGkAtoms::legend &&
> (!aParentFrame ||
> (aParentFrame->GetType() != nsGkAtoms::fieldSetFrame &&
> aParentFrame->GetStyleContext()->GetPseudo() !=
> nsCSSAnonBoxes::fieldsetContent) ||
>- !aContent->GetParent() ||
>- !aContent->GetParent()->IsHTML() ||
>- aContent->GetParent()->Tag() != nsGkAtoms::fieldset ||
>+ !aElement->GetParent() ||
>+ !aElement->GetParent()->IsHTML() ||
>+ aElement->GetParent()->Tag() != nsGkAtoms::fieldset ||
Looks like this could be !aElement->GetParent()->IsHTML(nsGkAtoms::fieldset) too
![]() |
Assignee | |
Comment 3•14 years ago
|
||
Yeah, sure. I was more or less on autopilot for the search-and-replace there... ;) I'll make that change.
![]() |
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: [need gk2 ship] → fixed-in-birch
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
![]() |
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•