Closed
Bug 633022
Opened 14 years ago
Closed 14 years ago
URLs for revision provide a default results even for made up changesets
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lsblakk, Assigned: astoica)
References
Details
Attachments
(1 file)
|
1.75 KB,
patch
|
catlee
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
http://cruncher.build.mozilla.org/buildapi/reports/revision/try/y3f9crr3wer3
I can change any character in that url and still get a page with 0 builds, 0 results, and is_complete: yes
In terms of being able to give feedback properly in tools (eg: bug 430942) that are basing themselves on this information, I would prefer to get a 404 for non existent changesets
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•14 years ago
|
||
returns 404 if revision doesn't exist and 400 if revision number is not exactly 12 characters long
Attachment #513176 -
Flags: review?(catlee)
Attachment #513176 -
Flags: checked-in?
|
||
Updated•14 years ago
|
Attachment #513176 -
Flags: review?(catlee)
Attachment #513176 -
Flags: review+
Attachment #513176 -
Flags: checked-in?
Attachment #513176 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•