633041 - Bug.add_attachment is missing an error code and should fill in content_type for patches

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Max Kanat-Alexander]

Attachment: v1, for 4.0

When writing the test in bug 629161 I discovered a few issues with Bug.add_attachment:

* It was missing an error code for attaching an empty "data" value.
* You should be able to set "is_patch => 1" without specifying a content type, and the content type should always be forced to "text/plain" for patches, but the backend wasn't doing this properly.

Comment 1

[Frédéric Buclin]

Comment on attachment 511246 [details] [diff] [review]
v1, for 4.0

Looks good, but only works for 4.0. is_url no longer exists in 4.1.

Comment 2

[Max Kanat-Alexander]

Attachment: v1, trunk

Okay, here's a similar patch for trunk.

Comment 3

[Frédéric Buclin]

Comment on attachment 511555 [details] [diff] [review]
v1, trunk

>=== modified file 'Bugzilla/Attachment.pm'

>+use constant VALIDATOR_DEPENDENCIES => {
>+    mimetype => ['ispatch', 'isurl'],
>+};

isurl no longer exists on trunk. r=LpSolit with this one removed.

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Attachment.pm
modified Bugzilla/WebService/Bug.pm
modified Bugzilla/WebService/Constants.pm
Committed revision 7696.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Attachment.pm
modified Bugzilla/WebService/Bug.pm
modified Bugzilla/WebService/Constants.pm
Committed revision 7543.