Last Comment Bug 633126 - Port Bug 590268 [Provide access to sessionstore tab data sooner] to SeaMonkey
: Port Bug 590268 [Provide access to sessionstore tab data sooner] to SeaMonkey
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Misak Khachatryan
:
Mentors:
Depends on: 590268
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-10 02:09 PST by Misak Khachatryan
Modified: 2011-02-10 23:26 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
straight port (1.97 KB, patch)
2011-02-10 02:09 PST, Misak Khachatryan
neil: review+
Details | Diff | Splinter Review

Description Misak Khachatryan 2011-02-10 02:09:50 PST
Created attachment 511327 [details] [diff] [review]
straight port

From parent bug:

Tab Candy needs this; otherwise we don't get our tab location data right at
start up.
Comment 1 neil@parkwaycc.co.uk 2011-02-10 08:19:37 PST
Comment on attachment 511327 [details] [diff] [review]
straight port

I was thinking they could have just written them as rather long || statements, but somehow I doubt that would have passed review ;-)
Comment 2 neil@parkwaycc.co.uk 2011-02-10 08:24:18 PST
Just for the record, those rather long || statements look like this!

return (aTab.__SS_extdata ||
        (aTab.linkedBrowser.__SS_data &&
         aTab.linkedBrowser.__SS_data.extData) ||
        {})[aKey] || "";

(aTab.__SS_extdata ||
 (aTab.linkedBrowser.__SS_data && 
  aTab.linkedBrowser.__SS_data.extData) ||
 (aTab.__SS_extdata = {}))[aKey] = aStringValue;
Comment 3 Philip Chee 2011-02-10 21:27:18 PST
Much more compact but clear as mud!
Comment 4 Misak Khachatryan 2011-02-10 23:26:26 PST
Pushed: http://hg.mozilla.org/comm-central/rev/c92d62353031

Note You need to log in before you can comment on or make changes to this bug.