move away from the page by file drop is possible in spite of modal file picker dialog

RESOLVED FIXED in mozilla9

Status

()

Core
Widget: Win32
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Kuno Meyer, Assigned: bbondy)

Tracking

({regression})

Trunk
mozilla9
x86
Windows XP
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 -)

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b11) Gecko/20100101 Firefox/4.0b11
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b11) Gecko/20100101 Firefox/4.0b11

It is possible to move away from a web page by "file drop" even if that page has a modal file picker dialog open. This seems inconsistent, since FF otherwise enforces the modality of the dialog and even prevents tab switching.

Reproducible: Always

Steps to Reproduce:
1. Go to a web page with a file picker (e.g. http://www.freepdfconvert.com/)
2. Open the file picker by clicking on "browse" --> a modal dialog appears
3. Drag a local file into the web page area in the background of the modal picker dialog, drop it there.
Actual Results:  
The file content gets loaded into the browser. The old page is gone.

Expected Results:  
File dropping should not be possible while the file picker is open.

Comment 1

7 years ago
Regression window(cached m-c hourly):
Works:
http://hg.mozilla.org/mozilla-central/rev/522df66198cf
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100624 Minefield/3.7a6pre ID:20100624185700
Fails:
http://hg.mozilla.org/mozilla-central/rev/51bd519736c4
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100624 Minefield/3.7a6pre ID:20100624221810
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=522df66198cf&tochange=51bd519736c4
Blocks: 513162
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
Component: Drag and Drop → Widget: Win32
Ever confirmed: true
Keywords: regression
QA Contact: drag-drop → win32

Updated

7 years ago
Version: unspecified → Trunk
This is a regression but I don't think it's worth blocking on.
blocking2.0: ? → -
(Assignee)

Updated

6 years ago
Assignee: nobody → netzen
(Assignee)

Updated

6 years ago
Depends on: 357601
(Assignee)

Comment 3

6 years ago
Adding a depends on Bug 357601 not because the regression was introduced there (that's not even pushed yet), but because the fix I made is based on code in my patch queue that is in Bug 357601.
(Assignee)

Comment 4

6 years ago
Created attachment 551485 [details] [diff] [review]
Patch for file picker's parent accepts drops in spite of file picker being modal.
Attachment #551485 - Flags: review?(neil)

Comment 5

6 years ago
Comment on attachment 551485 [details] [diff] [review]
Patch for file picker's parent accepts drops in spite of file picker being modal.

Might want to use mWindow->IsEnabled instead.
(Assignee)

Comment 6

6 years ago
Created attachment 551624 [details] [diff] [review]
Patch for file picker's parent accepts drops in spite of file picker being modal.

Implemented review comments.
Attachment #551485 - Attachment is obsolete: true
Attachment #551624 - Flags: review?(neil)
Attachment #551485 - Flags: review?(neil)

Comment 7

6 years ago
Comment on attachment 551624 [details] [diff] [review]
Patch for file picker's parent accepts drops in spite of file picker being modal.

>+  nsWindow * wnd = static_cast<nsWindow *>(mWindow);
I said mWindow->IsEnabled; no need to cast! r=me with that fixed.
(Assignee)

Comment 8

6 years ago
Created attachment 552575 [details] [diff] [review]
Fix for drag and drop when picker is open w/ latest review comments implemented
Attachment #551624 - Attachment is obsolete: true
Attachment #552575 - Flags: review?(neil)
Attachment #551624 - Flags: review?(neil)

Updated

6 years ago
Attachment #552575 - Flags: review?(neil) → review+
(Assignee)

Comment 9

6 years ago
Created attachment 552923 [details] [diff] [review]
Fix for drag and drop when picker is open w/ latest review comments implemented
Attachment #552575 - Attachment is obsolete: true
Attachment #552923 - Flags: review+
(Assignee)

Updated

6 years ago
Blocks: 573321
(Assignee)

Comment 10

6 years ago
This was pushed to try, results in progress:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=cde44aaad760
(Assignee)

Comment 11

6 years ago
Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/191f7bab5f5a
http://hg.mozilla.org/mozilla-central/rev/191f7bab5f5a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.