Closed
Bug 633218
Opened 15 years ago
Closed 15 years ago
Add removeOnDismissal option to addons notifications that should go away after restart (addons manager restart notification can persist when restart is no longer needed)
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 4.0b12
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
(Whiteboard: [doorhanger][softblocker][pre-approved by beltzner])
Attachments
(1 file)
|
1.14 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Follow-up to bug 587587.
|
Assignee | |
Comment 1•15 years ago
|
||
Requesting blocking, since this is the original issue that caused bug 587857 to block.
blocking2.0: --- → ?
|
||
Updated•15 years ago
|
blocking2.0: ? → final+
Summary: Add removeOnDismissal option to addons notifications that should go away after restart → Add removeOnDismissal option to addons notifications that should go away after restart (addons manager restart notification can persist when restart is no longer needed)
Whiteboard: [doorhanger] → [doorhanger][softblocker]
|
|
Assignee | |
Comment 2•15 years ago
|
||
Assignee: nobody → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #512621 -
Flags: review?(gavin.sharp)
|
||
Comment 3•15 years ago
|
||
If this passes reviews, it has implicit a=beltzner
Whiteboard: [doorhanger][softblocker] → [doorhanger][softblocker][pre-approved by beltzner]
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 512621 [details] [diff] [review]
patch
Add a comment explaining the reasoning? Something like "Have this notification remove itself on dismissal, since it's possible to cancel the install through the addons manager UI, after which the "restart" prompt is no longer relevant." (but maybe more concise!)
Attachment #512621 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Verified fixed with Firefox 4.0b12pre 20110218.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•