633234 - Test failure 'could not find element ID: toggle_PersonalToolbar' in testDefaultBookmarks/test1.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Module:    restartTests/testDefaultBookmarks/test1.js
Test:      testVerifyDefaultBookmarks    
Failure:   could not find element ID: toggle_PersonalToolbar 
Branches:  default
Platforms: Linux

To make the personal toolbar visible on Linux we currently right click the navigation toolbar at position (1,1). Starting from today that doesn't work anymore on Linux. No context menu pops-up and that's why toggle_PersonalToolbar cannot be found.

Checking the pushlog between yesterdays and todays build shows the following changesets:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd0817e454fe&tochange=199cb6282554

Dao, after talking with Mak we highly suspect that the patch on bug 631698 has been caused this regression. Is this definitely an intended change? If yes, we would have to update the Mozmill test to click on (width/2,2) which works.

Comment 1

[Dão Gottwald [:dao]]

I can't tell whether it's an intended change, as the problem isn't really clear to me. Is this just some obscure test failure or can you manually reproduce broken behavior?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Simplified testcase

This is the simplified testcase. To reproduce the following steps are necessary:

1. Create a fresh profile
2. Install Mozmill https://addons.mozilla.org/de/firefox/addon/mozmill/
3. Copy&Paste the test into the Mozmill IDE
4. Run the test

With builds prior to today the bookmarks toolbar will be visible. With todays build we fail in opening the context menu of the navbar.

Comment 3

[Dão Gottwald [:dao]]

No, I meant actually using the mouse and trying to reproduce the problem.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Manually I can't open the context menu either, but that problem seems to persist already a bit longer. It looks like that the buttons take all the available space. And manually clicking at (1,1) is a bit hard to do.

Comment 5

[Dão Gottwald [:dao]]

The problem might be that I removed the navigation toolbar's top border. This is intentional, the test would need to deal with that.

(In reply to comment #4)
> It looks like that the buttons take all the available space.

This is expected behavior.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, so formerly we clicked on the border, now it's the back button itself, which doesn't have a context menu when disabled. Given that this behavior is wanted, I will change our test to click at (width/2,2) of the navigation bar.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Comment 8

[Dão Gottwald [:dao]]

Why is the second argument 2 rather than 1?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For safety. We had a couple of situations in the past when we failed clicking at an offset with 1. Same issues have been seen in Mochitest, which also use 2 or even the center of the element now.

Comment 10

[Dão Gottwald [:dao]]

2 isn't safer than 1. Clicking further down makes it more likely to hit the location bar, which you don't want.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have a top padding of 4px for the urlbar. That would even give us 2 more pixel to click on, compared to 0px to the border of the navbar when clicking on 1.

Comment 12

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 511464 [details] [diff] [review]
Patch v1

Looks fine. I usually prefer a quick comment above this sort of thing that explains why the specific coords though (// click center below the border, something like that). Helps with maintenance later.

Your call, though. r+ either way.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v2

Patch with additional comment added.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/9d80953bf21c