633267 - SHGetSpecialFolderLocation + SHGetPathFromIDList should be replaced by the more efficient SHGetSpecialFolderPath (similar to bug 104962)

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Xiaoming Shi]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.44 Safari/534.7
Build Identifier: 

SHGetSpecialFolderLocation + SHGetPathFromIDList 

should be replaced by SHGetSpecialFolderPath which is much more efficient.

(The check of the availability of SHGetSpecialFolderPath is needed)

./mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp   line: 1964 - 1968
./mozilla/modules/libpr0n/decoders/icon/win/nsIconChannel.cpp           line: 281 - 285



Reproducible: Always

Comment 1

[Kevin Brosnan]

What is this reported against? ActiveX embedding has been removed from the tree.

Comment 2

[Xiaoming Shi]

Hi Kevin,

This is in the source code of mozilla-central (Main development Tree).

Is it in the Firefox tree? If not, sorry for the inconvenience.

Comment 4

[Ed Morley [:emorley]]

The ActiveX embedding API was removed in bug 662023 and friends, this just leaves the:

> /modules/libpr0n/decoders/icon/win/nsIconChannel.cpp           line: 281

part of comment 0.

Moving to ImageLib for someone else to make a call on this.

Note there may be other instances in mozilla-central, haven't checked.