SHGetSpecialFolderLocation + SHGetPathFromIDList should be replaced by the more efficient SHGetSpecialFolderPath (similar to bug 104962)

NEW
Unassigned

Status

()

8 years ago
7 years ago

People

(Reporter: xiaoming, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.44 Safari/534.7
Build Identifier: 

SHGetSpecialFolderLocation + SHGetPathFromIDList 

should be replaced by SHGetSpecialFolderPath which is much more efficient.

(The check of the availability of SHGetSpecialFolderPath is needed)

./mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp   line: 1964 - 1968
./mozilla/modules/libpr0n/decoders/icon/win/nsIconChannel.cpp           line: 281 - 285



Reproducible: Always

Comment 1

8 years ago
What is this reported against? ActiveX embedding has been removed from the tree.
(Reporter)

Comment 2

8 years ago
Hi Kevin,

This is in the source code of mozilla-central (Main development Tree).

Is it in the Firefox tree? If not, sorry for the inconvenience.
Version: unspecified → 3.6 Branch

Updated

8 years ago
Duplicate of this bug: 634311
(Reporter)

Updated

8 years ago
Component: General → Embedding: ActiveX Wrapper
Product: Firefox → Core
Version: 3.6 Branch → 1.9.2 Branch
(Reporter)

Updated

8 years ago
Version: 1.9.2 Branch → Trunk
QA Contact: general → activex

Comment 4

7 years ago
The ActiveX embedding API was removed in bug 662023 and friends, this just leaves the:

> /modules/libpr0n/decoders/icon/win/nsIconChannel.cpp           line: 281

part of comment 0.

Moving to ImageLib for someone else to make a call on this.

Note there may be other instances in mozilla-central, haven't checked.
Status: UNCONFIRMED → NEW
Component: Embedding: ActiveX Wrapper → ImageLib
Ever confirmed: true
QA Contact: activex → imagelib
Summary: Bug the same as Mozilla Bug 104962 → SHGetSpecialFolderLocation + SHGetPathFromIDList should be replaced by the more efficient SHGetSpecialFolderPath (similar to bug 104962)
You need to log in before you can comment on or make changes to this bug.