Checksum generation (build/checksums.py) needs to open files in binary mode for correct checksums

RESOLVED FIXED in mozilla2.0b12

Status

defect
RESOLVED FIXED
9 years ago
8 months ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified
mozilla2.0b12
x86
Windows XP

Firefox Tracking Flags

(status1.9.2 unaffected, status1.9.1 unaffected)

Details

Attachments

(1 attachment)

One of the SeaMonkey contributors noticed that our checksums were wrong for our latest beta.

This checksum file for us is generated from http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/packager.mk#708 which runs http://mxr.mozilla.org/comm-central/source/mozilla/build/checksums.py

The issue stems from the fact that checksums.py is not opening the files in binary mode. nthomas independantly (after being told about the issue) checked Firefox and noticed it also encounters this bug, and verified the binary-mode in the script here fixes it.

[n.b. catlee was the first to vocalize the binary mode suggestion] It also affects nightly checksums (like the complete mars)
Attachment #511626 - Flags: review?(ted.mielczarek)
Attachment #511626 - Flags: feedback?(nrthomas)
Attachment #511626 - Flags: feedback?(nrthomas) → feedback+
Comment on attachment 511626 [details] [diff] [review]
open in binary mode

Nice catch!
Attachment #511626 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 511626 [details] [diff] [review]
open in binary mode

a=beltzner
Attachment #511626 - Flags: approval2.0+
Pushed: http://hg.mozilla.org/mozilla-central/rev/da205ca44184
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.