633423 - Checksum generation (build/checksums.py) needs to open files in binary mode for correct checksums

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Justin Wood (:Callek)]

One of the SeaMonkey contributors noticed that our checksums were wrong for our latest beta.

This checksum file for us is generated from http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/packager.mk#708 which runs http://mxr.mozilla.org/comm-central/source/mozilla/build/checksums.py

The issue stems from the fact that checksums.py is not opening the files in binary mode. nthomas independantly (after being told about the issue) checked Firefox and noticed it also encounters this bug, and verified the binary-mode in the script here fixes it.

[n.b. catlee was the first to vocalize the binary mode suggestion] It also affects nightly checksums (like the complete mars)

Comment 1

[Justin Wood (:Callek)]

Attachment: open in binary mode

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 511626 [details] [diff] [review]
open in binary mode

Nice catch!

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 511626 [details] [diff] [review]
open in binary mode

a=beltzner

Comment 4

[Nochum Sossonko [:Natch]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/da205ca44184