Closed
Bug 633524
Opened 14 years ago
Closed 14 years ago
When maximising window with scroll buttons visible, they remain in tab bar (aero glass only)
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 4.0b12
People
(Reporter: josh.tumath+bugzilla, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.33 KB,
patch
|
fryn
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110211 Firefox/4.0b12pre
This bug is exactly the same as bug 624157, but is instead caused by a regression of bug 610080. See bug 624157 comment 0 for a description.
Reproducible: Always
|
Reporter | |
Updated•14 years ago
|
Blocks: 610080
Keywords: regression
Hardware: x86_64 → All
See Also: → 624157
Version: unspecified → Trunk
|
||
Comment 1•14 years ago
|
||
I see this bug, but I haven't yet identified the cause.
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 2•14 years ago
|
||
Shouldn't this block final?
|
|
Reporter | |
Comment 3•14 years ago
|
||
Possibly. Bug 624157 was flagged as not a blocker, so I don't see why this one would be. However, I suppose it's worth nominating just in case. It could be fixed in a minor release.
blocking2.0: --- → ?
|
Assignee | |
Comment 4•14 years ago
|
||
I don't see how bug 610080 would have caused this. Bug 631698 probably regressed this.
|
|
Assignee | |
Updated•14 years ago
|
Summary: When maximising window with scroll buttons visible, they remain in tab bar → When maximising window with scroll buttons visible, they remain in tab bar (aero glass only)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Dynamically changing the position of the <scrollbox> or any of its ancestors causes this bug, probably because the scroll frame is recreated or something. Doing it for the inner <box> however isn't a problem.
Attachment #513044 -
Flags: review?(fryn)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #513044 -
Flags: review?(gavin.sharp)
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 513044 [details] [diff] [review]
patch
The change looks fine.
How did |position: relative;| help fix bug 617506 ?
Attachment #513044 -
Flags: review?(gavin.sharp)
Attachment #513044 -
Flags: review?(fryn)
Attachment #513044 -
Flags: review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
position:relative is needed to let the tabs overlay the nav bar's top border.
In bug 617506, things were slightly more complicated. The top border had to overlay the tabs, except for the selected tab.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #513044 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #513044 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
|
|
||
Comment 9•14 years ago
|
||
Wonder why adding this to userchrome.css still causes this bug:
.tabbrowser-tab {margin-right: -1px !important;}
|
||
Comment 10•14 years ago
|
||
Verified fixed on Mozilla/5.0 (Windows NT 6.1; rv:2.2a1pre) Gecko/20110404 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•