When split menus are hovered, both the main item and expansion arrow should display on mouse in

RESOLVED FIXED in Firefox 4.0b12

Status

()

Firefox
Menus
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: faaborg, Assigned: Margaret)

Tracking

unspecified
Firefox 4.0b12
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 -, status2.0 wanted)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When split menus are hovered, both the main item and expansion arrow should display simultaneously on mouse in (of either item).

Currently the main item hover effect displays on mouse in, and then the expansion arrow hover effect displays on a timer delay.

The windows 7 start menu can be used as a reference for the behavior.  Note that this bug just covers displaying the hover effect (in the current style).  Additional styling work is covered over in bug 628049.
I'd like to nominate this for blocking final. 

The reason is that the new menu is one of the first things people encounter in Firefox 4, and the current hover behavior makes it feel unstable and weird, since it doesn't match the hover and display behaviors elsewhere in the OS.
blocking2.0: --- → ?
The other half of this fix is bug 628048.
Unstable is pretty strong for describing this. Weird... yes, a bit. The menu does display, just after a slight delay, so not blocking on this. It's a nice bit of interaction polish, but we can't keep shipping Firefox 3.6 just for this change. blocking- and wanted+.
blocking2.0: ? → -
status2.0: --- → wanted
(Assignee)

Updated

7 years ago
Blocks: 589146
(Assignee)

Comment 4

7 years ago
Created attachment 512514 [details] [diff] [review]
patch
Assignee: nobody → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #512514 - Flags: review?(dao)
Comment on attachment 512514 [details] [diff] [review]
patch

Along with this I think we need a 1px margin between the two parts, otherwise they won't be distinguishable if the theme draws a solid background for active items.
Attachment #512514 - Flags: review?(dao) → review-
(Assignee)

Comment 6

7 years ago
Created attachment 512568 [details] [diff] [review]
patch v2

Added 1px between two parts of split menu. I didn't know if the styles should be in content or theme, so I just put them in theme.
Attachment #512514 - Attachment is obsolete: true
Attachment #512568 - Flags: review?(dao)
(Reporter)

Comment 7

7 years ago
>Added 1px between two parts of split menu. I didn't know if the styles should
>be in content or theme, so I just put them in theme.

Thanks, I was actually going to request that as well :)
Comment on attachment 512568 [details] [diff] [review]
patch v2

>--- a/browser/themes/gnomestripe/browser/browser.css
>+++ b/browser/themes/gnomestripe/browser/browser.css

>+.splitmenu-menuitem {
>+  -moz-margin-end: 1px;
>+}
>+
> /* Application menu toolbar button */

Please move the comment up and change it to /* Application button menu */.
r=me with that
Attachment #512568 - Flags: review?(dao) → review+
(Assignee)

Comment 9

7 years ago
http://hg.mozilla.org/mozilla-central/rev/45895e0903f2
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Target Milestone: --- → Firefox 4.0b12

Updated

7 years ago
Depends on: 635249
You need to log in before you can comment on or make changes to this bug.