633661 - After context menu of addons is closed, buttons are not correctly repainted

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110209 Firefox/4.0b12pre ID:20110209030359

After using the context menu of individual add-on entries to check for updates, the buttons are only half repainted. You will have to hover over it to make the buttons re-appear. It happens with hardware acceleration enabled and disabled. For an example see the screenshot.

Regressed between the builds 11020603 and 11020703.

PASS: http://hg.mozilla.org/mozilla-central/rev/5bf94fcd5115
FAIL: http://hg.mozilla.org/mozilla-central/rev/4c62984f12d1

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bf94fcd5115&tochange=4c62984f12d1

Not sure yet which is the right component. So sticking it into Add-ons Manager for now. I will do a hg bisect.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The first bad revision is:
changeset:   62087:fffaf649c714
user:        Simon Montagu <[e-mail]>
date:        Mon Feb 07 09:59:20 2011 +0200
summary:     Bug 508816 - layout patch

Bug 508816 was a hardblocker which regressed this failure in repainting the buttons. Highly visible when working with the addons manager.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The fix for bug 632379 may help here.

Comment 3

[Simon Montagu :smontagu]

I am unable to reproduce this. Can you retest now that bug 632379 has landed?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed by bug Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110209 Firefox/4.0b12pre ID:20110209030359