Closed Bug 633666 Opened 9 years ago Closed 9 years ago

PathifyURI breaks caching of packed XPI js components

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: mwu, Assigned: mwu)

References

Details

(Keywords: regression)

Attachments

(1 file)

PathifyURI checks the return value of GetHost. GetHost is not always implemented, particularly on jar uris. JAR uris are very common when loading js components from packed XPIs. This results in js components from packed extensions not getting cached. Appears to be a regression from bug 609785.
Attachment #511893 - Flags: review?(benjamin)
blocking2.0: --- → ?
OS: Linux → All
Hardware: x86_64 → All
Attachment #511893 - Flags: review?(benjamin) → review+
What's the impact of them not being cached?  Correctness?  Performance in some cases?

This has review, so let's get it in, but if it bounces I think it bounces for good.
blocking2.0: ? → -
http://hg.mozilla.org/mozilla-central/rev/7464e26236cb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.