633715 - Port |Bug 593687 - Once open Add-ons Manager from popup window, can not get back previous contents| to SeaMonkey

Status: NEW

(SeaMonkey :: General, defect)

Comment 1

[Philip Chee]

Our fix can be significantly simpler since our openUILinkIn() actually returns a tab/window.

Comment 2

[Ian Neal]

As there should be no string changes, blocking on final

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

I don't get how to put comment 1 in context so I guess I should better not do this.

I found however that the base bug removed the aCallback parameter from switchToTabHavingURI (which is in our utilityOverlay.js) which is not only used for switching the view of the AOM but also our Data Manager. The base bug added some observers for the AOM (mozapps extensions.js), so if we were to follow suit removing aCallback we'd probably have to introduce the observers for the Data Manager, too.

aCallback users on our side:
tasksOverlay.js (2x)
tests/browser/browser_isempty.js

Comment 4

[Justin Wood (:Callek)]

(In reply to comment #2)
> As there should be no string changes, blocking on final

IanN this is unowned and I don't see a clear "why we should block" written in the bug (from serge's request). So can we re-evaluate this and/or get someone to own it?

Comment 5

[Philip Chee]

From Bug 593687 Comment 0

> Steps to Reproduce:
> 1. Open a popup window.  I mean js-opened window without toolbar.
>    If you don't know/have appropriate site/page, go to this test page: 
>     
> http://homepage3.nifty.com/chado/moz_work/window_open/open_sized_window_mini.html
>      and click the "open" button: 
> 2. Press keyboard shortcut: Ctrl+Shift+A.
> 
> Actual Results:  
> Add-ons Manager comes into the popup window.  Present trunk builds 
> don't support tabs in popup window.  So, previous contents are gone.
> There is no way to get back.  When the previous page contain any FORM 
> data, it cause dataloss.

Actual results in 2.1pre:
1. Tab bar appears and the Addons Manager opens in a new tab.
2. Tab can be closed by the [x] close button on the tab bar.
2a. Can also tab back to the tab that contains the original tab.

So nice to have but not a blocker.

Comment 6

[Robert Kaiser]

(In reply to comment #3)
> I don't get how to put comment 1 in context so I guess I should better not
> do this.
> 
> I found however that the base bug removed the aCallback parameter from
> switchToTabHavingURI (which is in our utilityOverlay.js) which is not only
> used for switching the view of the AOM but also our Data Manager. The base
> bug added some observers for the AOM (mozapps extensions.js), so if we were
> to follow suit removing aCallback we'd probably have to introduce the
> observers for the Data Manager, too.
> 
> aCallback users on our side:
> tasksOverlay.js (2x)
> tests/browser/browser_isempty.js

Yes, this is a major pain for any one who wants to call in-tab UI with some "parameters"... :(

Comment 7

[Ian Neal]

Missed 2.2, might make 2.3/2.4