633804 - Per-user install will overwrite registry key for other architectures.

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
1. Launch a 32-bit Minefield installer.
2. Cancel an UAC dialog and continue to install.
3. Make sure HKCU\Software\Mozilla\Minefield 4.0b12pre and HKCU\Software\Mozilla\Minefield\4.0b12pre (en-US)
4. Launch a 64-bit Minefield installer.
5. Cancel an UAC dialog and continue to install.
Actual result:
HKCU\Software\Mozilla\Minefield 4.0b12pre and HKCU\Software\Mozilla\Minefield\4.0b12pre (en-US) are overwritten because HKCU is not virtualized for 32-bit apps.
Expected result:
Registry key names under HKCU should contain the architecture such as "4.0b12pre (x86 en-US)". Uninstall strings already contain it.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 8398827 [details] [diff] [review]
patch rev1

Review of attachment 8398827 [details] [diff] [review]:
-----------------------------------------------------------------

We'll be leaving behind a key that looks like:
HKEY_CURRENT_USER\Software\Mozilla\Nightly\31.0a1 (en-US) that is unused.
An uninstall will clean it up, but I think most users probably won't be uninstalling any time soon. 
Should we do a DeleteRegKey with the old key location?

Comment 3

[Robert Strong (they/them - no direct email)]

iirc RegCleanMain takes care of this but it has been awhile since I last verified it (probably back when I first wrote it ;). I'll check and re-request.

Comment 4

[Brian R. Bondy [:bbondy]]

Thanks!

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: screenshots - before and after

It does clean it up though as previously the "Nightly 31.0a1" key is in the same state as it was before in that it is overwritten for the two. If that were to be handled I'd prefer providing the information under the following location instead
Nightly
  31.0a1 (x86 en-US)
    Components <path_to_components>
    PathToExe  <path_to_exe>
    Plugins    <path_to_plugins>

These are very old keys and I have not heard of anyone using them so if they are fixed I'd prefer to do it in a followup bug.

Comment 6

[Brian R. Bondy [:bbondy]]

[15:16:16] <bbondy> rstrong: ping
[15:16:40] <bbondy> did you try testing bug 633804 by installing both an x86 and an x64 build on your machine? (both patched x86 and x64)
[15:17:09] <bbondy> I'm just wondering that if the non architecture keys get cleaned, wouldn't the other architecture key also get cleaned

Comment 7

[Robert Strong (they/them - no direct email)]

<rstrong> bbondy: I didn't but they definitely should since it isn't dependent on the arch. It is dependent on the product name (e.g. Nightly in this case) and it enumerates subkeys

Comment 8

[Robert Strong (they/them - no direct email)]

I'll go ahead and build x64 and verify though.

Comment 9

[Brian R. Bondy [:bbondy]]

Comment on attachment 8398827 [details] [diff] [review]
patch rev1

Review of attachment 8398827 [details] [diff] [review]:
-----------------------------------------------------------------

Based on the IRC discussion about how cleanup works this looks good.

Comment 10

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/ce6c24dd1fae

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce6c24dd1fae