White-on-yellow close button is hard to see (missing-plugin infobar)

RESOLVED FIXED in mozilla2.0b12

Status

()

--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jruderman, Assigned: rik)

Tracking

({regression})

Trunk
mozilla2.0b12
x86
macOS
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

8 years ago
Created attachment 512044 [details]
screenshot of missing-plugin infobar

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b12pre) Gecko/20110212 Firefox/4.0b12pre

I think this is a regression from bug 589219, which added toolkit/themes/pinstripe/global/notification/close.png.
Yeah, that's kinda ugly.
(Assignee)

Comment 2

8 years ago
True.

Do you have a page to reproduce that? I can't find a page that triggers this yellow notification.
(Assignee)

Comment 3

8 years ago
Created attachment 512149 [details]
Screenshot with normal icon

Tried using the standard icon for warning messages.

+notification[type="warning"] .messageCloseButton {
+  list-style-image: url("chrome://global/skin/icons/close.png");
+}
(Assignee)

Comment 4

8 years ago
Created attachment 512150 [details]
Screenshot with normal icon - hover

Is it ok to reuse an image in another folder?
(Assignee)

Comment 5

8 years ago
Oh and I should add that there is also a red version of this bar. [type=critical]
(Assignee)

Comment 6

8 years ago
Created attachment 513071 [details] [diff] [review]
Patch
Assignee: nobody → anthony
Status: NEW → ASSIGNED
Attachment #513071 - Flags: review?(dao)
Attachment #513071 - Flags: review?(dao) → review+
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Severity: minor → trivial
These yellow and red bars do not exist in other platforms?
(Assignee)

Comment 8

8 years ago
Created attachment 513119 [details] [diff] [review]
Patch with mercurial info

This is the same patch with additional mercurial infos for checkin.
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #513071 - Flags: approval2.0?
BTW, forget comment 7... I should think of using my brain sometimes...
Comment on attachment 513071 [details] [diff] [review]
Patch

a=beltzner
Attachment #513071 - Flags: approval2.0? → approval2.0+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/3a1bdbbca259
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.