633847 - White-on-yellow close button is hard to see (missing-plugin infobar)

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Jesse Ruderman]

Attachment: screenshot of missing-plugin infobar

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b12pre) Gecko/20110212 Firefox/4.0b12pre

I think this is a regression from bug 589219, which added toolkit/themes/pinstripe/global/notification/close.png.

Comment 1

[Justin Dolske [:Dolske]]

Yeah, that's kinda ugly.

Comment 2

[Anthony Ricaud (:rik)]

True.

Do you have a page to reproduce that? I can't find a page that triggers this yellow notification.

Comment 3

[Anthony Ricaud (:rik)]

Attachment: Screenshot with normal icon

Tried using the standard icon for warning messages.

+notification[type="warning"] .messageCloseButton {
+  list-style-image: url("chrome://global/skin/icons/close.png");
+}

Comment 4

[Anthony Ricaud (:rik)]

Attachment: Screenshot with normal icon - hover

Is it ok to reuse an image in another folder?

Comment 5

[Anthony Ricaud (:rik)]

Oh and I should add that there is also a red version of this bar. [type=critical]

Comment 6

[Anthony Ricaud (:rik)]

Attachment: Patch

Comment 7

[Mounir Lamouri (:mounir)]

These yellow and red bars do not exist in other platforms?

Comment 8

[Anthony Ricaud (:rik)]

Attachment: Patch with mercurial info

This is the same patch with additional mercurial infos for checkin.

Comment 9

[Mounir Lamouri (:mounir)]

BTW, forget comment 7... I should think of using my brain sometimes...

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 513071 [details] [diff] [review]
Patch

a=beltzner

Comment 11

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/3a1bdbbca259