nsGlobalWindow.cpp:6430: warning: unused variable 'cx' (remove unused variable)

RESOLVED WORKSFORME

Status

()

Core
DOM
RESOLVED WORKSFORME
8 years ago
7 years ago

People

(Reporter: dholbert, Assigned: Ms2ger)

Tracking

Trunk
mozilla6
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
As noted in bug 621764 comment 22, that bug's checkin introduced this warning, from an unused variable:
> dom/base/nsGlobalWindow.cpp: In member function 'virtual void nsGlobalWindow::LeaveModalState(nsIDOMWindow*)':
> dom/base/nsGlobalWindow.cpp:6430: warning: unused variable 'cx'

Code:
> 6430   JSContext *cx = nsContentUtils::GetCurrentJSContext();

dolske tells me over email that this line was left over from an earlier patch incarnation, and it now wants to just be removed.
(Reporter)

Updated

8 years ago
Blocks: 621764
Whiteboard: [build_warning] → [build_warning] [good first bug]
(Assignee)

Comment 1

8 years ago
Created attachment 518012 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #518012 - Flags: review?(dolske)
(Assignee)

Updated

8 years ago
Whiteboard: [build_warning] [good first bug] → [build_warning][needs review]
Comment on attachment 518012 [details] [diff] [review]
Patch v1

Oops. This is is already taken care of by the patch in bug 635888, which is just waiting for the tree to reopen.

r+ except for that. ;-)
Attachment #518012 - Flags: review?(dolske)
Depends on: 635888
Whiteboard: [build_warning][needs review] → [build_warning]
(Assignee)

Comment 3

7 years ago
That works too. Thanks.
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.