Closed Bug 633953 Opened 9 years ago Closed 9 years ago

separate pre push checks and pre-release virus scan

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rail)

References

Details

(Whiteboard: [releases])

Attachments

(3 files, 4 obsolete files)

Currently, doing the pre-release virus scan is blocked on all of the pre push permission checks succeeding. This is unfortunate in cases where one of the pre push checks fail, because the virus scan ends up being delayed until we can make it pass. This sometimes delays the release. There's no reason to block the virus scan on these checks succeeding, so we should do them in parallel.
Assignee: nobody → rail
Priority: P3 → P2
Hardware: x86_64 → x86
Attached patch scripts (obsolete) — Splinter Review
* push-to-mirrors.py accepts "permissions", "antivirus", and "push" parameters
* dry run rsync is run after both "permissions" and "antivirus"
Attachment #512175 - Flags: review?(bhearsum)
Attached patch buildbotcustom (obsolete) — Splinter Review
* not tested yet
* revision and release_config properties are required by push-to-mirrors scripts. revision is set to a "floating" revision (FIREFOX_*_RELEASE), release_config is passed from buildbot-configs (see the next patch), so the builders are still reconfig safe.
* push_to_mirrors still requires revision and release_config to be set manually (it's safer)
* The patch should also fix bug 633957, you'll just need to rebuild check_permissions and antivirus builders manually, w/o setting any properties.
Attachment #512178 - Flags: feedback?(bhearsum)
Attached patch configsSplinter Review
Attachment #512179 - Flags: feedback?(bhearsum)
Whiteboard: [releases]
Attachment #512179 - Flags: feedback?(bhearsum) → feedback+
Comment on attachment 512178 [details] [diff] [review]
buildbotcustom

This is good overall, but I explicitly don't want revision to be set, because it changes per-release. I know it's overridable, but in new code I want to avoid *anything* being set at reconfig that changes per-release. Definitely like the releaseConfigFile stuff.
Attachment #512178 - Flags: feedback?(bhearsum) → feedback-
Attachment #512175 - Flags: review?(bhearsum) → review+
Comment on attachment 512178 [details] [diff] [review]
buildbotcustom

Rail reminded me that these aren't being force build'ed. It sucks that we require a reconfig for this, but it's unavoidable for now. Post signing on demand these can be Dependent fired, and we can drop the revision/script_repo_revision Builder properties at that point.
Attachment #512178 - Flags: feedback- → feedback+
Comment on attachment 512179 [details] [diff] [review]
configs

Nothing changed here after a staging run.
Attachment #512179 - Flags: review?(bhearsum)
Attached patch scripts (obsolete) — Splinter Review
This version should also fix bug 634237. The documentation should be updated as well.
Attachment #512175 - Attachment is obsolete: true
Attachment #512591 - Flags: review?(bhearsum)
Attachment #512179 - Flags: review?(bhearsum) → review+
Attached patch buildbotcustom (obsolete) — Splinter Review
* -        builderNames=builderPrefix(...)
  +        builderNames=[builderPrefix(...)]
* Fixes bug 634237 as well
Attachment #512178 - Attachment is obsolete: true
Attachment #512593 - Flags: review?(bhearsum)
Attached patch scriptsSplinter Review
Updated diff
Attachment #512591 - Attachment is obsolete: true
Attachment #513480 - Flags: review?(bhearsum)
Attachment #512591 - Flags: review?(bhearsum)
Attached patch buildbotcustomSplinter Review
Updated against bug 635150
Attachment #512593 - Attachment is obsolete: true
Attachment #513481 - Flags: review?(bhearsum)
Attachment #512593 - Flags: review?(bhearsum)
Attachment #513480 - Flags: review?(bhearsum) → review+
Attachment #513481 - Flags: review?(bhearsum) → review+
Yay! I see new builders on the waterfall pages. :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.